Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shuffle data when generate #401

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Shuffle data when generate #401

merged 2 commits into from
Jan 29, 2024

Conversation

SpriCoder
Copy link
Collaborator

@SpriCoder SpriCoder commented Jan 29, 2024 •
edited
Loading

In formal implementation, the data of same timestamp are same even if in different devices. This pr fix this problem

liyuheng55555
liyuheng55555 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@liyuheng55555 liyuheng55555 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Now workload's col selection is related to deviceId.

@SpriCoder SpriCoder merged commit b599a8e into master Jan 29, 2024
1 check passed
@SpriCoder SpriCoder deleted the feature/mix-data branch January 29, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyuheng55555 liyuheng55555 liyuheng55555 approved these changes

@OneSizeFitsQuorum OneSizeFitsQuorum Awaiting requested review from OneSizeFitsQuorum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpriCoder @liyuheng55555