-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify POM files #500
Comments
especially, Chris says,
If you have any questions, ask in the mail list. |
补充剩下邮件的内容
All non-binary files need the ASF header
I wouldn’t produce fat jars (using the assembly plugin) as this bundles classes in to a library that might be used in another application that has dependencies to the same libraries but in a different version … trust me … these are the worst problems to track down.
|
@jixuan1989 How do you think about KV-match integration? Remove for now or what? Perhaps we need a discussion. |
@MyXOF can you double-check all of these? |
1. remove the header description of the parent pom file. (YCSB and others)
2. The parent pom in the root has to be set to “org.apache:apache:21”
3. remove
developers
section from pom files4. re-check all the profiles. If they are duplicated with apache:21 parent pom, remove them.
5. change the name of
<project.version>0.8.0-SNAPSHOT</project.version>
from root pom.xml (Do not use the default parameterproject.version
)6. Replace the antrun plugin with the dependencies plugin for copying the libs to the iotdb/lib directory (antrun is highly deprecated)
7. No need to re-define the license, scm, distribution management in sub-modules
8. Try to unify the plugin definitions in the root pom.
9. You are relying on Java 8 so the Jodatime library is included in general there is no need to use the external library and the included classes could be used)
10. generate a
-with-dependencies.jar
by assembly plugin11. remove
iotdb/iotdb/src/main/resources/META-INF/MANIFEST.MF
12. check the dependency of antlr3
13. remove kvmatch-iotdb dependency.
@kr11 please ask the corresponding person.
14. JDBC pom: You are adding a “interface/thrift” directory to the sources, but that doesn’t exist.
15. Move the interfaces thirft files to “src/main/thrift” and have the code generated on every build to “target/generated-sources” (default)
16. TsFile pom: You are adding a “interface/thrift” directory to the sources, but that doesn’t exist.
17. Spark module: remove tsfile data file.
The text was updated successfully, but these errors were encountered: