Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify POM files #500

Open
14 of 17 tasks
jixuan1989 opened this issue Dec 12, 2018 · 4 comments
Open
14 of 17 tasks

modify POM files #500

jixuan1989 opened this issue Dec 12, 2018 · 4 comments

Comments

@jixuan1989
Copy link
Member

jixuan1989 commented Dec 12, 2018

  • 1. remove the header description of the parent pom file. (YCSB and others)

  • 2. The parent pom in the root has to be set to “org.apache:apache:21”

  • 3. remove developers section from pom files

  • 4. re-check all the profiles. If they are duplicated with apache:21 parent pom, remove them.

Maybe it’s worth configuring the maven-javadoc-plugin in a pluginManagement section of the root to exclude them in general and get rid of the “release” profiles in general

  • remove nexus-staging-maven-plugin
  • 5. change the name of <project.version>0.8.0-SNAPSHOT</project.version> from root pom.xml (Do not use the default parameter project.version)

  • 6. Replace the antrun plugin with the dependencies plugin for copying the libs to the iotdb/lib directory (antrun is highly deprecated)

  • 7. No need to re-define the license, scm, distribution management in sub-modules

  • 8. Try to unify the plugin definitions in the root pom.

  • 9. You are relying on Java 8 so the Jodatime library is included in general there is no need to use the external library and the included classes could be used)

  • 10. generate a -with-dependencies.jar by assembly plugin

  • 11. remove iotdb/iotdb/src/main/resources/META-INF/MANIFEST.MF

  • 12. check the dependency of antlr3

You have a dependency on the antlr3 maven plugin. Instead you should depend on the antlr-runtime artifact that matches your antlr3 version.

  • 13. remove kvmatch-iotdb dependency.
    @kr11 please ask the corresponding person.

  • 14. JDBC pom: You are adding a “interface/thrift” directory to the sources, but that doesn’t exist.

  • 15. Move the interfaces thirft files to “src/main/thrift” and have the code generated on every build to “target/generated-sources” (default)

  • 16. TsFile pom: You are adding a “interface/thrift” directory to the sources, but that doesn’t exist.

  • 17. Spark module: remove tsfile data file.

@jixuan1989
Copy link
Member Author

especially, Chris says,

do not check in the generated code.

If you have any questions, ask in the mail list.

@MyXOF MyXOF mentioned this issue Dec 12, 2018
@MyXOF
Copy link
Collaborator

MyXOF commented Dec 12, 2018

补充剩下邮件的内容

  • 18. 所有非lib的类加上Apache的声明。

All non-binary files need the ASF header

  • 19. 现有pom里面的release插件和Apache release 冲突
  • You are defining a “release” profile which is obviously intended for releasing. This will not apply as apache releases are performed with the “apache-release” profile. So if important stuff is to be done here (it actually shouldn’t)
    * From a quick look all defined there is also done by the profile defined in the “apache-release” profile in the “apache” parent pom. So all except the exclusion for package names including “thrift” could simply be removed. (Maybe it’s worth configuring the maven-javadoc-plugin in a pluginManagement section of the root to exclude them in general and get rid of the “release” profiles in general)
    * Especially the staging part has to be removed as you will be staging to repository.apache.org instead of the oss sonatype repo.
  • 20. 不用assembly拆件打打jar包。

I wouldn’t produce fat jars (using the assembly plugin) as this bundles classes in to a library that might be used in another application that has dependencies to the same libraries but in a different version … trust me … these are the worst problems to track down.

  • 21. kvmatch

@wujysh
Copy link
Collaborator

wujysh commented Dec 13, 2018

@jixuan1989 How do you think about KV-match integration? Remove for now or what? Perhaps we need a discussion.

@jixuan1989
Copy link
Member Author

@MyXOF can you double-check all of these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants