Updating package definition, minimum platform versions as well as dependencies #161
Conversation
Muhieddine-El-Kaissi
commented
Apr 25, 2024
•
Muhieddine-El-Kaissi
commented
- Updating package definition to 5.10
- Updating minimum platform versions to iOS 15 & OS 14
- Updating swift version to 5.10
- Cleaning up RXswift lint
- Updating swiftlint & swift format as well as applying fixes to the code
Muhieddine-El-Kaissi
force-pushed
the
m/upgrade
branch
from
d58a964 to
d44ca3f
Compare
Muhieddine-El-Kaissi
changed the title
| steps: | ||
| - name: 📥 Checkout | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Select Xcode | ||
| run: sudo xcode-select -s "/Applications/Xcode_15.3.app" |
There was a problem hiding this comment.
I don't think you can do this ? These are githubs machines, not ours.
There was a problem hiding this comment.
it's the work around proposed in https://stackoverflow.com/a/73896628/695599 and it fixed the lint issue we are seeing previously
There was a problem hiding this comment.
it's very strange to me that you can run sudo at all here 🤔
There was a problem hiding this comment.
yeah we need sudo and it's proposed by the actions :)
There was a problem hiding this comment.
it's not proposed by the actions, but by xcode-select. It doesn't know it's run from github.
There was a problem hiding this comment.
There was a problem hiding this comment.
The vms aren't dedicated though, so i think you'd run into it again. I think eventually you'd be able to drop it when 5.10 is the default they have etc.
Muhieddine-El-Kaissi
force-pushed
the
m/upgrade
branch
from
3d4e0cf to
f2af6c9
Compare
Muhieddine-El-Kaissi
force-pushed
the
m/upgrade
branch
from
ca0e213 to
f2af6c9
Compare
