Features/448 health check v2 (#489)

* Convert REDIS_USE_SSL into a boolean

* Update main health check to throw 503's if mysql or redis (optional) is down.

* Debug

* Remove debug, and fix env -> bool conversion

* Fix tests

* Remove print

backend/.env.test

@@ -2,7 +2,7 @@
 
 # -- GENERAL --
 # Logging level: DEBUG|INFO|WARNING|ERROR|CRITICAL
-LOG_LEVEL=ERROR
+LOG_LEVEL=DEBUG
 LOG_USE_STREAM=1
 
 # -- FRONTEND --
@@ -90,7 +90,7 @@ GOOGLE_TEST_PASS=
 TEST_USER_EMAIL=[email protected]
 
 # -- Redis --
-REDIS_URL=localhost
+REDIS_URL
 REDIS_PORT=6379
 REDIS_DB=0
 # No value = Python None

backend/src/appointment/dependencies/database.py

@@ -39,7 +39,7 @@ def get_redis() -> Redis | RedisCluster | None:
     port = int(os.getenv('REDIS_PORT'))
     db = os.getenv('REDIS_DB')
     password = os.getenv('REDIS_PASSWORD')
-    ssl = os.getenv('REDIS_USE_SSL')
+    ssl = True if os.getenv('REDIS_USE_SSL') and (os.getenv('REDIS_USE_SSL').lower() == 'true' or os.getenv('REDIS_USE_SSL').lower() == '1') else False
 
     if os.getenv('REDIS_USE_CLUSTER'):
         return RedisCluster(

backend/src/appointment/l10n/en/main.ftl

@@ -7,6 +7,7 @@ locale = en
 
 # Should indicate application wellness.
 health-ok = Health OK
+health-bad = Health BAD
 
 ## General Exceptions
 

backend/src/appointment/main.py

@@ -38,7 +38,8 @@
 
 def _common_setup():
     # load any available .env into env
-    load_dotenv()
+    if os.getenv('APP_ENV') != APP_ENV_TEST:
+        load_dotenv()
 
     # This needs to be ran before any other imports
     normalize_secrets()

backend/src/appointment/routes/api.py

@@ -1,12 +1,15 @@
+import enum
 import os
 import secrets
+from enum import Enum
 
 import requests.exceptions
+import sentry_sdk
 from redis import Redis, RedisCluster
 
 # database
 from sqlalchemy.orm import Session
-from starlette.responses import HTMLResponse
+from starlette.responses import HTMLResponse, JSONResponse
 
 from .. import utils
 from ..database import repo, schemas
@@ -29,9 +32,23 @@
 
 
 @router.get('/')
-def health():
+def health(db: Session = Depends(get_db)):
     """Small route with no processing that will be used for health checks"""
-    return l10n('health-ok')
+    try:
+        db.query(Subscriber).first()
+    except Exception as ex:
+        sentry_sdk.capture_exception(ex)
+        return JSONResponse(content=l10n('health-bad'), status_code=503)
+
+    if os.getenv('REDIS_URL'):
+        try:
+            redis_instance: Redis | RedisCluster | None = get_redis()
+            redis_instance.ping()
+        except Exception as ex:
+            sentry_sdk.capture_exception(ex)
+            return JSONResponse(content=l10n('health-bad'), status_code=503)
+
+    return JSONResponse(l10n('health-ok'), status_code=200)
 
 
 @router.put('/me', response_model=schemas.SubscriberBase)

backend/test/conftest.py

@@ -23,7 +23,7 @@
 from factory.invite_factory import make_invite  # noqa: F401
 
 # Load our env
-load_dotenv(find_dotenv('.env.test'))
+load_dotenv(find_dotenv('.env.test'), override=True)
 
 from appointment.main import server  # noqa: E402
 from appointment.database import models, repo, schemas  # noqa: E402