Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite #207

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Vite #207

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions frontend/.env.example
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
# Appointment frontend configuration.

# -- Frontend --
VUE_APP_BASE_URL=localhost:8080
VUE_APP_SHORT_BASE_URL=localhost:8080/user
VITE_BASE_URL=localhost:8080
VITE_SHORT_BASE_URL=localhost:8080/user

# -- Backend API --
VUE_APP_API_URL=localhost
VUE_APP_API_PORT=8090
VUE_APP_API_SECURE=false
VITE_API_URL=localhost
VITE_API_PORT=8090
VITE_API_SECURE=false

# -- Sentry --
VUE_APP_SENTRY_DSN=
VITE_SENTRY_DSN=

# -- Auth scheme --
VUE_APP_AUTH_SCHEME=password
VITE_AUTH_SCHEME=password

# For fxa
VUE_APP_FXA_EDIT_PROFILE=
VITE_FXA_EDIT_PROFILE=
12 changes: 6 additions & 6 deletions frontend/.env.staging.example
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Production env config, do not put secrets in here !!
VUE_APP_API_URL=stage.appointment.day/api/v1/
VUE_APP_BASE_URL=stage.appointment.day
VUE_APP_API_SECURE=true
VUE_APP_SHORT_BASE_URL=https://stage.apmt.day
VITE_API_URL=stage.appointment.day/api/v1/
VITE_BASE_URL=stage.appointment.day
VITE_API_SECURE=true
VITE_SHORT_BASE_URL=https://stage.apmt.day

# -- Auth scheme --
VUE_APP_AUTH_SCHEME=fxa
VITE_AUTH_SCHEME=fxa

# For fxa
VUE_APP_FXA_EDIT_PROFILE=https://accounts.stage.mozaws.net/settings
VITE_FXA_EDIT_PROFILE=https://accounts.stage.mozaws.net/settings
74 changes: 40 additions & 34 deletions frontend/.eslintrc.js → frontend/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,34 +1,40 @@
module.exports = {
env: {
browser: true,
es2021: true,
},
extends: [
'plugin:vue/vue3-essential',
'airbnb-base',
],
overrides: [],
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
},
plugins: [
'vue',
],
rules: {
'import/extensions': ['error', 'ignorePackages', {
'': 'never',
js: 'never',
vue: 'off', // TODO: once migrated to Vite, we should set this to 'always'
}],
'max-len': ['error', { code: 120 }],
'no-param-reassign': 'off',
},
settings: {
'import/resolver': {
webpack: {
config: require.resolve('@vue/cli-service/webpack.config.js'),
},
},
},
};
/* eslint-env node */
require('@rushstack/eslint-patch/modern-module-resolution');

module.exports = {
env: {
browser: true,
es2021: true,
},
extends: [
'plugin:vue/vue3-essential',
'airbnb-base',
],
overrides: [],
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
},
plugins: [
'vue',
],
rules: {
'import/extensions': ['error', 'ignorePackages', {
'': 'never',
js: 'never',
vue: 'off',
}],
'max-len': ['error', {code: 120}],
'no-param-reassign': 'off',
},
settings: {
'import/resolver': {
alias: {
map: [
['@', './src'],
],
extensions: ['.js', '.vue'],
},
},
},
};
3 changes: 3 additions & 0 deletions frontend/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,6 @@ pnpm-debug.log*
*.njsproj
*.sln
*.sw?

# Sentry Config File
.env.sentry-build-plugin
26 changes: 13 additions & 13 deletions frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
FROM node:lts-alpine
WORKDIR /app
ENV PATH /app/node_modules/.bin:$PATH
# Get git
RUN apk add --no-cache git
COPY . .
RUN yarn install
CMD vue-cli-service serve
FROM node:lts-alpine

WORKDIR /app

ENV PATH /app/node_modules/.bin:$PATH

# Get git
RUN apk add --no-cache git

COPY . .
RUN yarn install

CMD vite dev --port 8080
4 changes: 2 additions & 2 deletions frontend/deploy.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ apt-get install -y nodejs

# Build site
RUN cd /build/frontend && npm install
RUN cd /build/frontend && npm run build-stage
RUN cd /build/frontend && npm run build -- --mode staging

# Use our custom nginx config
RUN rm /etc/nginx/conf.d/default.conf
COPY docker/etc/nginx/conf.d/appointments.conf /etc/nginx/conf.d/default.conf

RUN cp -r /build/frontend/dist/. /usr/share/nginx/html

EXPOSE 80
EXPOSE 80
11 changes: 5 additions & 6 deletions frontend/public/index.html → frontend/index.html
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
<!DOCTYPE html>
<html lang="">
<head>
<title><%= htmlWebpackPlugin.options.title %></title>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width,initial-scale=1.0">
<link rel="icon" href="<%= BASE_URL %>appointment_logo.svg">
<meta charset="UTF-8">
<link rel="icon" href="/appointment_logo.svg">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Thunderbird Appointment</title>
<script>
// handle theme color scheme
if (
Expand All @@ -26,6 +25,6 @@
</strong>
</noscript>
<div id="app" class="h-full"></div>
<!-- built files will be auto injected -->
<script type="module" src="/src/main.js"></script>
</body>
</html>
19 changes: 4 additions & 15 deletions frontend/jsconfig.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,9 @@
{
"compilerOptions": {
"target": "ES6",
"module": "esnext",
"baseUrl": "./",
"moduleResolution": "node",
"jsx": "preserve",
"paths": {
"@/*": [
"src/*"
]
},
"lib": [
"esnext",
"dom",
"dom.iterable",
"scripthost"
]
}
"@/*": ["./src/*"]
}
},
"exclude": ["node_modules", "dist"]
}
Loading