Add minimum_valid_iat_time to subscriber table, and hook up the rest of the fxa webhook events 🛢
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iber factory not setting email correctly.
MelissaAutumn
changed the title
minimum_valid_iat_time to subscriber tableminimum_valid_iat_time to subscriber table, hook up the rest of the fxa webhook events
MelissaAutumn
changed the title
minimum_valid_iat_time to subscriber table, hook up the rest of the fxa webhook eventsminimum_valid_iat_time to subscriber table, and hook up the rest of the fxa webhook events
MelissaAutumn
commented
Jan 10, 2024
MelissaAutumn
commented
Jan 10, 2024
devmount
changed the title
minimum_valid_iat_time to subscriber table, and hook up the rest of the fxa webhook eventsminimum_valid_iat_time to subscriber table, and hook up the rest of the fxa webhook events 🛢
devmount
approved these changes
Jan 12, 2024
...igrations/versions/2024_01_09_1652-ad7cc2de5ff8_add_minimum_valid_iat_time_to_subscribers.py
Show resolved
Hide resolved
...igrations/versions/2024_01_09_1652-ad7cc2de5ff8_add_minimum_valid_iat_time_to_subscribers.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix all of the tasks in #220
This add a
minimum_valid_iat_timeto the Subscriber's table. This field is used to quickly block any old/logged out access tokens. Normally we'd have a self-cleaning deny list, but we don't have redis or another caching mechanism setup that would make it easy to add in. This should cover our needs for now though.For context:
iatis the issued at time for a jwt. If we set theminimum_valid_iat_timeto the forced logout time it would prevent any previously valid jwt tokens from being used. If a user logs themselves out then we don't set aminimum_valid_iat_time.I've also hooked up the delete-user event (ref: https://github.com/mozilla/fxa/blob/main/packages/fxa-event-broker/README.md) and added test for each webhook event we handle.
I also fixed a frontend oopsie I discovered while testing out primary email changes on fxa. (By adding a
+to my email.)🛢 This change requires a db migration