Cron / Updated cli #234
Merged
Cron / Updated cli #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmount
approved these changes
Jan 22, 2024
| @@ -12,6 +12,11 @@ COPY requirements.txt . | |||
| COPY pyproject.toml . | |||
| COPY alembic.ini.example alembic.ini | |||
| COPY scripts/entry.sh scripts/entry.sh | |||
| COPY scripts/cron /etc/cron.d/appointment-cron | |||
There was a problem hiding this comment.
This cron file is currently empty, right? Should we add an example entry here for convenience? Or add some documentation how to use it? Or is this handled by Typer automatically?
There was a problem hiding this comment.
Oh yea sorry, the cron is empty. Once we want to add stuff we'll just stuff it in that file and it should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230
I spent a while researching options for a cron scheduler, and they're all kind of ehh. I think it's okay to simply create some purpose built commands and add them manually to our cron file in scripts. Right now that file is empty, and the cron only runs on dev.
I've added typer CLI, which seems to be made by the same person as fastapi. (https://typer.tiangolo.com/typer-cli/) This replaces my if statement, and should allow us to easily create cli commands as needed. There's still no way to use the cli from aws though, so I expect only the update-db and cron commands will ever be made.
I've also added a helper contextmanager function to create and remove a lock file if one doesn't already exist. If you create a cron command, make sure to use it!