Add "Route Not Found" and "Require Authentication" views. #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Will redirect the user back to the intended page if logged in from that button. * Fixed double router-view elements which caused some onMounts to run twice.
MelissaAutumn
changed the title
devmount
approved these changes
Mar 15, 2024
|
Thanks! Sorry I forgot the l10n tag 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315
You'll now get either a Not Found or Auth Required page depending on what you hit in that url field vs logged in status.
Not authenticated:
Not found:
I had to merge the "Not authenticated" and "Is Public" app-level templates in order to fix a bug where having multiple router-view's causes onMounted to run multiple times. (Since we go from a isPublic to isAuth, the router-view for isAuth runs and refreshes the page.)
The redirect was actually quite easy to implement.