Add Privacy policy and Terms of service: #345
Conversation
* Uses Thunderbird's Privacy Policy. * Uses Website's Terms of Service. * Manual command to pull new legal updates as needed. * LegalView to pull down the html from the backend.
|
|
||
| extensions = ['markdown.extensions.attr_list'] | ||
| # Only english for now. There's no german TB privacy policy? | ||
| locales = ['en'] |
There was a problem hiding this comment.
I was going to pull based on locale, but legal doesn't have a german privacy policy for TB 🤔
There was a problem hiding this comment.
@Sancus who do we prod to get privacy policy translated?
There was a problem hiding this comment.
Well, if you have problems to find somebody 🤚🏻 I'm not exactly a professional translator but a native speaker at least 😅 I can provide a PR if you want.
There was a problem hiding this comment.
@devmount thanks for the offer! I'm looking into getting this translated right now. We should setup a pipeline for how to do it without relying on SDEs 😅
There was a problem hiding this comment.
Of course, still wanted to offer that 😇
|
looks okay for now, I've added a ticket to automate this process in the post-mvp doc. I'm proposing we make a scheduled task to run this command and check for changes. If there are changes, it'll open a PR with the change and notify us. |
There was a problem hiding this comment.
Should we document all commands in the readme? I always appreciate having commands listed somewhere with some simple example call.
| @@ -0,0 +1,53 @@ | |||
| <template> | |||
| <div v-html="pageContents"> | |||
There was a problem hiding this comment.
Are we 100% sure, that pageContents does not contain any user manipulated content? Thinking about XSS here. Maybe we can at least filter the contents for some predefined tags, or is v-html safer now than in the past?
There was a problem hiding this comment.
I can adjust this PR to generate a vue view component instead to resolve this. It's a good thing both projects are in the same repo.
There was a problem hiding this comment.
Yes I think that would be much better 👍🏻
…html files, and we should be good to go.
|
I kept the command, but just tell the person running it to copy the html files over to the frontend project lol. I then import it as raw text via vite, and use the v-html. Which is a-okay because it'll be compiled in, no network request needed. |
|
Added backend readme. I'll add more details at a later date. |
There was a problem hiding this comment.
Nice, thank you for this documentation 👏🏻
Co-authored-by: Andreas <[email protected]>
|
I'm going to merge this, we can look into German ToS/Privacy another time. |
* Add Privacy policy and Terms of service: * Uses Thunderbird's Privacy Policy. * Uses Website's Terms of Service. * Manual command to pull new legal updates as needed. * LegalView to pull down the html from the backend. * Download to tmp, tell the individual to copy 'em over. Pull in local html files, and we should be good to go. * Add backend readme. * Update backend/README.md Co-authored-by: Andreas <[email protected]> --------- Co-authored-by: Andreas <[email protected]>
Fixes #51
I was going to make this a plugin on the frontend to pull and render to html on vite build, but that would have taken longer lol. This is the simplest way, and when there's an update you just need to run
run-command main download-legal.If we're worried about io reads, I can hook the routes up to redis caching.
cc @Sancus @malini