Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted calendar settings flow #381

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Adjusted calendar settings flow #381

merged 2 commits into from
Apr 30, 2024

Conversation

MelissaAutumn
Copy link
Member

Fixes #377

This actually just adjusts the flow to be a little less destructive. We can revisit it after alpha though, it still is kinda janky.

  • You can now disconnect connected calendars without nuking them.
  • You can now remove (delete) calendars that are unconnected.
  • Sync still brings them back if they're from a google account.
  • Schedule Settings will become inactive if the connected calendar is disconnected.
  • Schedule Settings will be deleted if an unconnected calendar that is associated is deleted. (Cascade all from models.Calendar)
  • Schedule Settings becomes active if a previously unconnected calendar becomes connected again.
image image

@MelissaAutumn
Adjusted calendar settings flow:
f9b4937 
* You can now disconnect connected calendars without nuking them.
* You can now remove (delete) calendars that are unconnected.
* Sync still brings them back if they're from a google account.
* Schedule Settings will become inactive if the connected calendar is disconnected.
* Schedule Settings will be deleted if an unconnected calendar that is associated is deleted. (Cascade all from models.Calendar)
* Schedule Settings becomes active if a previously unconnected calendar becomes connected again.
@MelissaAutumn MelissaAutumn requested a review from devmount April 24, 2024 21:44
@MelissaAutumn MelissaAutumn self-assigned this Apr 24, 2024
@MelissaAutumn MelissaAutumn changed the title Adjusted calendar settings flow: Adjusted calendar settings flow Apr 24, 2024
@MelissaAutumn MelissaAutumn added the l10n update A string has been added or needs updating label Apr 24, 2024
devmount
devmount approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you! I sorted the lang keys and updated the German ones (I somehow seemed to have missed one PR on lang, so did some more additions here).

@MelissaAutumn MelissaAutumn merged commit 82e8ea8 into main Apr 30, 2024
2 checks passed
@MelissaAutumn MelissaAutumn deleted the bugs/377-fix-disconnecting-calendar-breaks-schedule branch April 30, 2024 15:06
devmount added a commit that referenced this pull request May 7, 2024
@devmount @MelissaAutumn @malini
Update from main (#391)
62a1aa5 
* Fix migration

* Error out the invite routes for now.

We need to add proper access control for these.

* Fix dropdown when nav is in mobile mode.

* Fix name case for unix systems.

* 🔨 Fix unreadable colored placeholder text (#368)

* Timezone information in booking confirmation email (#367)

* 🔨 fix case sensitive filename calls 🙈

* ➕ show timezone for attendee in confirmation email

* 🔨 extend schedule test with attendee timezone

* 🔨 Make attendee timezone mandatory

* 🔨 Fix appointment tests

* Completely disable 'pretty exceptions'.

* Rename Tooltip.vue to ToolTip.vue.

* Provide a default value for existing attendees.

* Fix schedule calendar being tooooo big

* Fix my default value fix

* General Availability Redesign (#374)

* Dark mode fixes for GA Redesign

* One last tweak

* Some final dark mode changes

* Homepage typo fix

* Fix sickening sticky movement on schedule settings, and try to make event day component behave.

* Remove chrome time icon that makes the time input overflow.

* Replace Confetti SVG with 🎉.

* Remove some old illustrations

* Implemented design review feedback:
* Required field (Name) now shows a red asterisk indicating its required
* Made error messages less round.

* New user experience fixes for Schedule Settings:
* Require a connected calendar in order to create a schedule
* Prompt the user to save to create a schedule if they have a calendar connected but no schedule.
* Consolidate component in <snackish-bar/>

* If we don't have a schedule just say it's not active.

* Add a touch function to mdoels.Base. This updates the time_updated (does not save.) And force a touch update after schedule creation

* Revert last commit

* Let's just try some defaults

* Update lang strings (#376)

* Legal and privacy should be public routes

* Move repository functions to own modules (#370)

* 🔨 Move repository functions to own modules

* 🧪 Test repo module init

* Hide unimplemented search

* Reduce sampling and profiling rate to 25% on stage/prod and ignore health check route

* Capture every error on prod for now

* Adjusted calendar settings flow (#381)

* Adjusted calendar settings flow:
* You can now disconnect connected calendars without nuking them.
* You can now remove (delete) calendars that are unconnected.
* Sync still brings them back if they're from a google account.
* Schedule Settings will become inactive if the connected calendar is disconnected.
* Schedule Settings will be deleted if an unconnected calendar that is associated is deleted. (Cascade all from models.Calendar)
* Schedule Settings becomes active if a previously unconnected calendar becomes connected again.

* 🌐 Update lang strings

---------

Co-authored-by: Andreas Müller <[email protected]>

* Ensure the incoming fxa uid matches all existing ones (there should only be one!) (#382)

* Fix 404 flashes (#383)

* 🔨 Handle lazy loaded routes with async components

* 🔨 Fix wrong route name

* 💚 Fix content x-padding for legal pages

* Add prototype notice to README.md

* Add production env for frontend

* update readme with topicbox (#386)

Co-authored-by: Malini Das <[email protected]>

* Constantify some more app environments

* Replace python-jose with PyJWT

* Convert the pem object to the key

* Adjust pem logic

Add leeway

* Add Google API Services disclosure.

* Watch dayBoundary and forward updates to Qalendar. (#389)

---------

Co-authored-by: Melissa Autumn <[email protected]>
Co-authored-by: Mel <[email protected]>
Co-authored-by: Malini Das <[email protected]>
Co-authored-by: Malini Das <[email protected]>
jdbass pushed a commit that referenced this pull request May 17, 2024
@MelissaAutumn @devmount @jdbass
Adjusted calendar settings flow (#381)
464a951 
* Adjusted calendar settings flow:
* You can now disconnect connected calendars without nuking them.
* You can now remove (delete) calendars that are unconnected.
* Sync still brings them back if they're from a google account.
* Schedule Settings will become inactive if the connected calendar is disconnected.
* Schedule Settings will be deleted if an unconnected calendar that is associated is deleted. (Cascade all from models.Calendar)
* Schedule Settings becomes active if a previously unconnected calendar becomes connected again.

* 🌐 Update lang strings

---------

Co-authored-by: Andreas Müller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmount devmount devmount approved these changes

Assignees

@MelissaAutumn MelissaAutumn

Labels
l10n update A string has been added or needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Availability link is not correct if you disconnect/reconnect the same calendar
2 participants
@MelissaAutumn @devmount