Fix 404 flashes #383
Merged
Fix 404 flashes #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmount
commented
Apr 30, 2024
| const AppointmentsView = defineAsyncComponent(() => import('@/views/AppointmentsView')); | ||
| const SettingsView = defineAsyncComponent(() => import('@/views/SettingsView')); | ||
| const ProfileView = defineAsyncComponent(() => import('@/views/ProfileView')); | ||
| const LegalView = defineAsyncComponent(() => import('@/views/LegalView')); |
There was a problem hiding this comment.
defineAsyncComponent has a lot more options we could use, e.g. show a placeholder component as long as it is still not fully loaded. But we could improve that in the future, if we like. For now, the page flashes white when fully reloading the browser and has a small delay, when navigating the page in app for the first time.
| @@ -1,6 +1,5 @@ | |||
| <template> | |||
| <div v-html="pageContents"> | |||
There was a problem hiding this comment.
How does this look when you view this page while logged in?
devmount
added a commit
that referenced
this pull request
May 7, 2024
* Fix migration * Error out the invite routes for now. We need to add proper access control for these. * Fix dropdown when nav is in mobile mode. * Fix name case for unix systems. * 🔨 Fix unreadable colored placeholder text (#368) * Timezone information in booking confirmation email (#367) * 🔨 fix case sensitive filename calls 🙈 * ➕ show timezone for attendee in confirmation email * 🔨 extend schedule test with attendee timezone * 🔨 Make attendee timezone mandatory * 🔨 Fix appointment tests * Completely disable 'pretty exceptions'. * Rename Tooltip.vue to ToolTip.vue. * Provide a default value for existing attendees. * Fix schedule calendar being tooooo big * Fix my default value fix * General Availability Redesign (#374) * Dark mode fixes for GA Redesign * One last tweak * Some final dark mode changes * Homepage typo fix * Fix sickening sticky movement on schedule settings, and try to make event day component behave. * Remove chrome time icon that makes the time input overflow. * Replace Confetti SVG with 🎉. * Remove some old illustrations * Implemented design review feedback: * Required field (Name) now shows a red asterisk indicating its required * Made error messages less round. * New user experience fixes for Schedule Settings: * Require a connected calendar in order to create a schedule * Prompt the user to save to create a schedule if they have a calendar connected but no schedule. * Consolidate component in <snackish-bar/> * If we don't have a schedule just say it's not active. * Add a touch function to mdoels.Base. This updates the time_updated (does not save.) And force a touch update after schedule creation * Revert last commit * Let's just try some defaults * Update lang strings (#376) * Legal and privacy should be public routes * Move repository functions to own modules (#370) * 🔨 Move repository functions to own modules * 🧪 Test repo module init * Hide unimplemented search * Reduce sampling and profiling rate to 25% on stage/prod and ignore health check route * Capture every error on prod for now * Adjusted calendar settings flow (#381) * Adjusted calendar settings flow: * You can now disconnect connected calendars without nuking them. * You can now remove (delete) calendars that are unconnected. * Sync still brings them back if they're from a google account. * Schedule Settings will become inactive if the connected calendar is disconnected. * Schedule Settings will be deleted if an unconnected calendar that is associated is deleted. (Cascade all from models.Calendar) * Schedule Settings becomes active if a previously unconnected calendar becomes connected again. * 🌐 Update lang strings --------- Co-authored-by: Andreas Müller <[email protected]> * Ensure the incoming fxa uid matches all existing ones (there should only be one!) (#382) * Fix 404 flashes (#383) * 🔨 Handle lazy loaded routes with async components * 🔨 Fix wrong route name * 💚 Fix content x-padding for legal pages * Add prototype notice to README.md * Add production env for frontend * update readme with topicbox (#386) Co-authored-by: Malini Das <[email protected]> * Constantify some more app environments * Replace python-jose with PyJWT * Convert the pem object to the key * Adjust pem logic Add leeway * Add Google API Services disclosure. * Watch dayBoundary and forward updates to Qalendar. (#389) --------- Co-authored-by: Melissa Autumn <[email protected]> Co-authored-by: Mel <[email protected]> Co-authored-by: Malini Das <[email protected]> Co-authored-by: Malini Das <[email protected]>
jdbass
pushed a commit
that referenced
this pull request
May 17, 2024
* 🔨 Handle lazy loaded routes with async components * 🔨 Fix wrong route name * 💚 Fix content x-padding for legal pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change contains:
defineAsyncComponentwhich handles the component resolutionlegal->termsBenefits
Improved UX.
Applicable Issues
Closes #378