Fix all day events bleeding over to following day:

[MelissaAutumn]

• Google defines all day as "Midnight" to "Midnight + 1 day"
• Subtract 1 minute from the end time.

Fixed:

Sample all day event:

{
	"11": {
		"title": "Test All Day",
		"start": "2024-05-10T00:00:00",
		"end": "2024-05-11T00:00:00",
		"all_day": true,
		"tentative": false,
		"description": "",
		"calendar_title": "<redacted>",
		"calendar_color": "#9fe1e7",
		"location": null,
		"uuid": null
	}
}

[devmount]

Good catch! Works for Google, but not for CalDAV it seems?

[MelissaAutumn]

Do you have a sample dump of what that calendar event looks like in ical?

Fastmail seems to use Duration instead of setting an end time (which we don't actually handle, so that fix is coming up!) which functionally works like Google.

[devmount]

This is the dump:

BEGIN:VEVENT
CREATED:20240513T080055Z
LAST-MODIFIED:20240513T080115Z
DTSTAMP:20240513T080115Z
UID:cg9ce9g7-arhe-o5li-47jh-2rqa03fyca1j
SUMMARY:AllDayTest
DTSTART;VALUE=DATE:20240514
DTEND;VALUE=DATE:20240515
TRANSP:OPAQUE
CLASS:PUBLIC
END:VEVENT

I used some random public test caldav server, so this might just be a weird implementation on server side. They obviously use all day events with excluded DTEND.

I will do some more testing on this.

[devmount]

I was able to reproduce this bug with a NextCloud CalDAV calendar. Here is the dump from the NExtCloud CalDAV event:

BEGIN:VEVENT
CREATED:20240524T130454Z
DTSTAMP:20240524T130503Z
LAST-MODIFIED:20240524T130503Z
SEQUENCE:2
UID:a6bc4c05-8feb-4b7c-aed5-111cb75d1bf3
DTSTART;VALUE=DATE:20240528
DTEND;VALUE=DATE:20240529
STATUS:CONFIRMED
SUMMARY:CalDAV TEST
END:VEVENT

Working on a fix.

[devmount]

Ok I don't know what I did wrong, but it suddenly works for all my CalDAV calendars 🙈 I guess my frontend container was in a weird state. When checking out that branch again and restarting the containers, it works now 😇

So your fix totally works for CalDAV too, sorry for this! At least we know now that Appointment supports Nextcloud calendars too 😅