Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/397 invite codes #427

Merged
merged 7 commits into from
May 24, 2024
Merged

Features/397 invite codes #427

merged 7 commits into from
May 24, 2024

Conversation

MelissaAutumn
Copy link
Member

Fixes #397

Invite Admin Panel:
Screen Shot 2024-05-23 at 15 00 03-fullpage

Login:
Screen Shot 2024-05-23 at 15 00 37-fullpage

This PR re-introduces the invite admin panel, which allows an admin to generate x number of invites, revoke unused invites, and filter on invites. A user can now optionally enter an invite, and if they're a new user it will "use" that invite allowing them to register. Otherwise they'll see an error.

There is also a navigation bar for the admin panel, and some additions to the data-table component like the ability to conditionally disable buttons.

@MelissaAutumn MelissaAutumn requested a review from devmount May 23, 2024 22:03
@MelissaAutumn MelissaAutumn self-assigned this May 23, 2024
@MelissaAutumn MelissaAutumn added the l10n update A string has been added or needs updating label May 23, 2024
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Mel! There it is again 😅

I added another table data type code, which preformats text and makes it copiable. I also completed translations and found a few minor things.

Comment on lines +92 to +93
"admin-invite-codes-panel": "Invites",
"admin-subscriber-panel": "Subscribers",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit odd to switch from camelCase to dash-case, but I guess that's because of the route names, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! I should just group those. 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, maybe just a section directly for route names...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'll make a ticket for it.

Comment on lines 17 to 19
<admin-nav>

</admin-nav>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there supposed to be a child element here or can we use a stand-alone tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformatting / editor shenanigans, I'll clean that up!

Comment on lines 17 to 19
<admin-nav>

</admin-nav>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And same here: Is there supposed to be a child element here or can we use a stand-alone tag?

@MelissaAutumn MelissaAutumn merged commit be6c0e6 into main May 24, 2024
4 checks passed
@MelissaAutumn MelissaAutumn deleted the features/397-invite-codes branch May 24, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n update A string has been added or needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Invite Codes
2 participants