Ensure a trailing slash for CalDAV urls #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course. I thought it was cleaner to have unified urls in the db, but you're right! It's better to leave the user input as is here 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change adds a slash
/to the end of CalDAV urls, when a CalDAV calendar is added or updated and the given url doesn't already end with one.I normally test with a public CalDavZIP instance (https://calendar.robur.coop/) but that currently seems to be down. I tested with a NextCloud calendar too and that was working just fine.
Benefits
Less complaints from picky CalDAV servers enforcing a trailing slash.
Applicable Issues
Closes #343