Restructure calendar components and fix remote tentative event styles #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce calendar month to mini version only
| }" | ||
| :style="{ | ||
| borderColor: !isMonthView ? eventColor(event, false).border : null, | ||
| backgroundColor: isMonthView || (!isMonthView && event.tentative) ? 'transparent' : event.calendar_color, |
There was a problem hiding this comment.
bg-amber-400/80 is being overwritten by transparent, and I think this is the cause. Can you confirm? Thanks!
There was a problem hiding this comment.
You mean for all day events? In which calendar mode?
There was a problem hiding this comment.
Yep sorry, all day events on the main calendar page for me!
There was a problem hiding this comment.
Yes I see, fixed it
MelissaAutumn
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The change disassembles the
CalendarEvent.vuecomponent into 4 components of different event states:Moreover a couple of components from the former calendar implementation were removed (CalendarDay.vue and CalendarWeek.vue). The CalendarMonth.vue component was renamed and reduced to a mini month component.
Moreover remote tentative events are now styled with transparent background and calendar colored border and text.
Benefits
This heavily enhances readability and makes styles on different event types changeable again.
Tentative remote events now look like this again in week/day view:
Applicable Issues
Closes #324