Add a preferred email option in account settings (Fixes #408) #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelissaAutumn
commented
May 30, 2024
| """Return the list of emails they can use within Thunderbird Appointment""" | ||
| google_connections = get_by_type(db, subscriber_id=subscriber.id, type=ExternalConnectionType.google) | ||
|
|
||
| emails = {subscriber.email, *[connection.name for connection in google_connections]} - {subscriber.preferred_email} |
There was a problem hiding this comment.
This should ensure there's no duplicates if they already have their preferred email set as their main email, or a google account email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408
This PR adds a dropdown to select the users preferred email with a tooltip explaining what that option does:
We don't have an email verification system, so I'm only pulling from FXA + Google Connections. So if you connect with your personal google account you can use that email for booking emails, and events.
To facilitate this functionality I've added a
secondary_emailaddress to the subscribers table, and apreferred_emailproperty to the subscribers model. Thepreferred_emailproperty returns either thesecondary_emailor if that's null, theemail. For any outgoing email usage you should always usepreferred_email.emailshould only be used in context of login/auth, andsecondary_emailshould only be used during updates relating to the dropdown.I believe I've caught all of the outgoing email usage, but feel free to let me know if I've missed anything.