Fix schedule event previews #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmount
commented
May 31, 2024
| @@ -87,7 +87,6 @@ const schedules = ref([]); | |||
| const firstSchedule = computed(() => (schedules.value?.length > 0 ? schedules.value[0] : null)); | |||
| const schedulesReady = ref(false); | |||
| const getFirstSchedule = async () => { | |||
| calendarEvents.value = []; | |||
There was a problem hiding this comment.
I didn't find any reason to keep this here. This was the cause for calendar events to disappear on schedule save.
devmount
commented
May 31, 2024
| @@ -107,6 +106,8 @@ const onDateChange = (dateObj) => { | |||
| const start = dj(dateObj.start); | |||
| const end = dj(dateObj.end); | |||
|
|
|||
| activeDate.value = start.add(end.diff(start, 'minutes')/2, 'minutes'); | |||
There was a problem hiding this comment.
We're now updating the selected date on navigation too, to keep the event generation in sync with the view
MelissaAutumn
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change does two things:
Benefits
More convenient display of elements in the calendar on availability configuration.
Applicable Issues
Closes #350