Chores/CS and linter fixes backend #457
Conversation
devmount
changed the title
|
Thanks for the config fixes! Seems like we might not need black anymore since ruff's formatter sells itself as a drop-in replacement. We should switch the quote style back to single quotes and try and fix the excessive param exploding when it comes to functions that contain a dictionary or list as its sole argument. |
|
I removed black and added a ruff rule to use single quotes (but somehow the single quotes don't get applied on fix 🤔 I'll investigate). Do you know which rule to add to fix the function parameters? Thanks! |
|
Ok for some reason the quotes config in pyproject.toml wasn't taken into account, so I manually ran this now: ruff format backend --config "format.quote-style = 'single'" |
|
I actually ran into this issue on a side project over the weekend, it's actually https://docs.astral.sh/ruff/settings/#lint_flake8-quotes_inline-quotes 🤔 |
|
I actually tried that too without success, but I can add it to the pyproject.toml nevertheless |
|
Ok, I now added the inline quotes rule as well. |
|
Thanks! |
| subscriber and subscriber.minimum_valid_iat_time and subscriber.minimum_valid_iat_time.timestamp() > int(iat) | ||
| ]): | ||
| if any( | ||
| [ |
There was a problem hiding this comment.
I agree, but I couldn't find a rule for that...
| { | ||
| "id": user.id, | ||
| } | ||
| ) |
| 'deny_url': self.denyUrl, | ||
| }) | ||
| return l10n( | ||
| "confirm-mail-plain", |
Description of the Change
This applies
blackandruffon our current backend. Seems like we didn't do that for quite some time 😅 Let me know, if you want to change any rules here, afaik we're just applying default rules and a few in pyproject.tomlBenefits
Consistent code base
Applicable Issues
None