Update regex to allow for spaces and plus signs, and remove the hash before booking. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malini
reviewed
Jun 26, 2024
| @@ -183,9 +183,10 @@ const bookEvent = async (attendeeData) => { | |||
| attendee: attendeeData, | |||
| }; | |||
|
|
|||
| const url = window.location.href.split('#')[0]; | |||
There was a problem hiding this comment.
Are we guaranteed to have a '#' in the href here?
There was a problem hiding this comment.
submitted too early. What happens if we get an error here?
There was a problem hiding this comment.
split will still return an array with the url. if theres a hash it will be length==2 instead of 1.
malini
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500
This only affects you if you dig into week or day view, but we handle it by removing the hash from the url before we send it up. So this applies it in the booking function.
Also retrieve_user_url_data basically takes
/mel/a6b24d4c/and splits it into (mel,a6b24d4c,/mel/a6b24d4c/). I'm starting to think we should just split by slash, but that can be another PR.