Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve caldav calendar settings flow #786

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

devmount
Copy link
Collaborator

@devmount devmount commented Dec 9, 2024

Description of the Change

This change improves the setup of new CalDAV connections.

  • Form fields are now validated and provide browser validation messages
  • CalDAV creds are now validated with error/success message
  • On success, the available calendars are automatically displayed

Benefits

Better feedback for users on CalDAV setup in settings.

appointment_caldav_settings_flow

Applicable Issues

Closes #777

@devmount devmount self-assigned this Dec 9, 2024
Copy link
Contributor

@radishmouse radishmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (Only commenting, as I haven't tested it)

Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I almost wonder if we should merge the single calendar connection with the modal.

Speaking of the modal, does this change affect the modal's caldav autodiscovery connection functionality? (i.e. do these errors show up properly on there too?)

@devmount
Copy link
Collaborator Author

Looks good, I almost wonder if we should merge the single calendar connection with the modal.

Speaking of the modal, does this change affect the modal's caldav autodiscovery connection functionality? (i.e. do these errors show up properly on there too?)

You mean the FTUE modal? The Authentication Error should show up there too, the rest of the change shouldn't effect it. I only took care of the calendar settings section with this. Should we create another ticket for FTUE?

@MelissaAutumn
Copy link
Member

Looks good, I almost wonder if we should merge the single calendar connection with the modal.
Speaking of the modal, does this change affect the modal's caldav autodiscovery connection functionality? (i.e. do these errors show up properly on there too?)

You mean the FTUE modal? The Authentication Error should show up there too, the rest of the change shouldn't effect it. I only took care of the calendar settings section with this. Should we create another ticket for FTUE?

At least for the investigation post this PR, and any work that may come from that.

Thanks!

@devmount
Copy link
Collaborator Author

Done (see #788). Thanks for the reviews!

@devmount devmount merged commit b09e318 into main Dec 10, 2024
4 checks passed
@devmount devmount deleted the bugs/777-improve-caldav-calendar-settings-flow branch December 10, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show an error message when unsuccessful at setting up a CalDAV connection
4 participants