Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browserstack session name #812

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

rwood-moz
Copy link
Contributor

@rwood-moz rwood-moz commented Jan 2, 2025

Currently when the production sanity test is ran via github actions, the same browserstack build name is used each time (every test run is added to the same browserstack Automate build). This change updates the test configuration so that we will have a separate browserstack build for each time the test runs. See comment below for new screenshots from BrowserStack.

@rwood-moz rwood-moz added the testing Issues specific to automated testing label Jan 2, 2025
@rwood-moz rwood-moz linked an issue Jan 2, 2025 that may be closed by this pull request
@rwood-moz rwood-moz force-pushed the testing/811-fix-session-name branch from 5d727ac to a3ef1ac Compare January 2, 2025 18:51
@rwood-moz rwood-moz force-pushed the testing/811-fix-session-name branch from a3ef1ac to 45489d0 Compare January 2, 2025 18:59
@rwood-moz
Copy link
Contributor Author

rwood-moz commented Jan 2, 2025

When run from a local machine the BrowserStack build name now includes the date/time:

Screenshot 2025-01-02 at 2 01 46 PM

And when run in CI via GHA the BrowserStack build name will be unique and include the build info from GHA (i.e. in this case the tests were triggered by a manual GHA workflow dispatch):

Screenshot 2025-01-02 at 2 11 01 PM

I added a new npm run prod-sanity-test-browserstack-gha command because when running in GHA we want the build name to come from the GHA workflow and not be overwritten by the command line.

@rwood-moz rwood-moz force-pushed the testing/811-fix-session-name branch from 45489d0 to 921fad4 Compare January 2, 2025 19:08
@rwood-moz rwood-moz changed the title [WIP] Fix browserstack session name Fix browserstack session name Jan 2, 2025
@rwood-moz rwood-moz force-pushed the testing/811-fix-session-name branch from 921fad4 to 06740ba Compare January 2, 2025 19:23
Copy link
Contributor

@jdbass jdbass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rwood-moz rwood-moz merged commit f005395 into main Jan 2, 2025
4 checks passed
@rwood-moz rwood-moz deleted the testing/811-fix-session-name branch January 2, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues specific to automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix production browserstack session name
2 participants