Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't name inline attachments. (Fixes #816) #817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't name inline attachments. (Fixes #816) #817

wants to merge 1 commit into from

Conversation

MelissaAutumn
Copy link
Member

Fixes #816

Previously Condition-Disposition was being set to attachment because we named the file. But we want it as an inline file, so don't name the file.

image

@MelissaAutumn MelissaAutumn requested a review from devmount January 7, 2025 21:30
@MelissaAutumn MelissaAutumn self-assigned this Jan 7, 2025
devmount
devmount approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such an easy fix, thank you!! Tested in Mailpit, TfA and Thunderbird ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmount devmount devmount approved these changes

Assignees

@MelissaAutumn MelissaAutumn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix inline images showing up as attachments in emails
2 participants
@MelissaAutumn @devmount