Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemoteCalendarConnectionError init #824

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

rwood-moz
Copy link
Contributor

@rwood-moz rwood-moz commented Jan 15, 2025

When a RemoteCalendarConnectionError() is raised and no reason is provided the result is a TypeErrror:

>               raise RemoteCalendarConnectionError()
E               TypeError: RemoteCalendarConnectionError.__init__() missing 1 required positional argument: 'reason'

There are several existing cases of RemoteCalendarConnectionError() being used with no reason value provided.

The fix is to have the RemoteCalendarConnectionError() reason parameter to have a default value of None.

@rwood-moz rwood-moz linked an issue Jan 15, 2025 that may be closed by this pull request
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@rwood-moz rwood-moz merged commit 0a71d46 into main Jan 15, 2025
4 checks passed
@rwood-moz rwood-moz deleted the bug/fix-validation-error branch January 15, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when raise RemoteCalendarConnectionError
2 participants