Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frontend eslint errors #843

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fix frontend eslint errors #843

merged 2 commits into from
Jan 31, 2025

Conversation

rwood-moz
Copy link
Contributor

@rwood-moz rwood-moz commented Jan 28, 2025 •
edited
Loading

Fix the frontend eslint (/frontend/npm run lint) errors to make the code a tiny bit neater.

I tested /frontend/npm run test and /frontend/npm run build and they worked fine with this PR.

@rwood-moz rwood-moz linked an issue Jan 28, 2025 that may be closed by this pull request
Fix frontend lint errors #837
Closed
@rwood-moz rwood-moz added testing Issues specific to automated testing frontend This affects the frontend application labels Jan 28, 2025
@rwood-moz rwood-moz force-pushed the testing/frontend-linting branch from d045b9a to d21bd20 Compare January 28, 2025 21:46
@rwood-moz rwood-moz marked this pull request as ready for review January 28, 2025 21:52
@rwood-moz rwood-moz mentioned this pull request Jan 29, 2025
Merged
devmount
devmount approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you for all those code improvements! Just one question.

frontend/.eslintrc.cjs Outdated Show resolved Hide resolved
@rwood-moz rwood-moz merged commit e02d7eb into main Jan 31, 2025
4 checks passed
@rwood-moz rwood-moz deleted the testing/frontend-linting branch January 31, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmount devmount devmount approved these changes

@MelissaAutumn MelissaAutumn MelissaAutumn left review comments

Assignees
No one assigned
Labels
frontend This affects the frontend application testing Issues specific to automated testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix frontend lint errors
3 participants
@rwood-moz @devmount @MelissaAutumn