Email template revamp #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwood-moz
reviewed
Feb 4, 2025
| @@ -14,7 +14,7 @@ user.init(call); | |||
| // handle ui languages | |||
| watch(locale, (newValue: string) => { | |||
| user.data.settings.language = newValue; | |||
| window.location.reload(); // This is needed to reload locale for dayjs instance | |||
| // This is needs a window.location.reload(); to reload locale for dayjs instance | |||
There was a problem hiding this comment.
tiny nit, typo: "this is needs a"
There was a problem hiding this comment.
Oh thanks for highlighting this one. I commented this out because this currently causes an issue of the language setting not being saved to db because the reload triggers too early. I'll fix that in another PR.
rwood-moz
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR revamps the email templates
Benefits
More consistent and less "spammy" email design.
Applicable Issues
Closes #815