Initial focus in message compose screen #8664
Conversation
shamim-emon
commented
Dec 11, 2024
shamim-emon
commented
- Deals with initial focus point on mail compose screen
- fixes Initial focus in message compose screen #7635
shamim-emon
force-pushed
the
fix-issue-7635
branch
from
35c28c5 to
56471f1
Compare
There was a problem hiding this comment.
For future changes: I think breaking down the code changes into separate commits would help us to review your changes better. Consider applying each change individually: move Java to a new class, then convert to Kotlin, and finally refactor.
Besides that it works as expected and it seems that the corner cases still work.
Just the RecipientMvpView doesn't need to be a member of MessageCompose as it's only needed during onCreate
| @@ -222,6 +223,7 @@ public class MessageCompose extends K9Activity implements OnClickListener, | |||
|
|
|||
| private Action action; | |||
|
|
|||
| private RecipientMvpView recipientMvpView; | |||
There was a problem hiding this comment.
Instead of creating a class member that could leak, it's better to keep it as is and change the messageLoaderCallbacks to a private class and inject the recipientMvpView when creating it.
private MessageLoaderCallbacks messageLoaderCallbacks = new MessageLoaderCallbacks() { private class MessageComposeMessageLoaderCallback implements MessageLoaderCallbacks {
private final RecipientMvpView recipientMvpView;
public MessageComposeMessageLoaderCallback(RecipientMvpView recipientMvpView) {
this.recipientMvpView = recipientMvpView;
}
...This is possible as recipientMvpView is only needed in onCreate.
| @@ -304,7 +306,7 @@ public void onCreate(Bundle savedInstanceState) { | |||
| ReplyToView replyToView = new ReplyToView(this); | |||
| replyToPresenter = new ReplyToPresenter(replyToView); | |||
|
|
|||
| RecipientMvpView recipientMvpView = new RecipientMvpView(this); | |||
| recipientMvpView = new RecipientMvpView(this); | |||
There was a problem hiding this comment.
See above regarding recipientMvpView
| @@ -1677,6 +1598,14 @@ public void onMessageDataLoadFailed() { | |||
| public void onMessageViewInfoLoadFinished(MessageViewInfo messageViewInfo) { | |||
| internalMessageHandler.sendEmptyMessage(MSG_PROGRESS_OFF); | |||
| loadLocalMessageForDisplay(messageViewInfo, action); | |||
|
|
|||
There was a problem hiding this comment.
See above regarding recipientMvpView
| import org.openintents.openpgp.util.OpenPgpApi | ||
|
|
||
| @Suppress("NestedBlockDepth", "MaxLineLength") | ||
| class IntentDataMapper { |
There was a problem hiding this comment.
Ideally this would be covered by tests.
