feat: improve custom loaded fonts #209

yisibl · 2023-02-14T13:25:18Z

The defaultFontFamily option can now be omitted when loading custom fonts. We'll read the font-family from the incoming fonts and set it to the default.

This feature is also available in Wasm (previously, loading fonts via the fontBuffers option was supported in Wasm).

const resvg = new Resvg(svg, {
    background: '#fff',
    font: {
      fontDirs: ['./__test__/'], // Load custom fonts from this directory.
      fontFiles: ['./example/SourceHanSerifCN-Light-subset.ttf'], // Load custom fonts from this file.
      loadSystemFonts: false, // It will be faster to disable loading system fonts.
      // defaultFontFamily: 'Source Han Serif CN Light',
    },
    logLevel: 'debug', // Default Value: error
  })
  const pngBuffer = resvg.render().asPng()

node example/text

[2023-08-06T15:40:50Z DEBUG resvg_js::fonts] 📝 default_font_family = Source Han Serif CN Light
[2023-08-06T15:40:50Z DEBUG resvg_js::fonts] Font './example/SourceHanSerifCN-Light-subset.ttf':0 found in 0.008ms.
[2023-08-06T15:40:50Z DEBUG resvg_js::fonts] Loaded 2 font faces in 0.425ms.
[2023-08-06T15:40:50Z WARN  usvg_text_layout] Fallback from Source Han Serif CN Light to Pacifico.

vercel · 2023-02-14T13:25:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
resvg-js	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 20, 2023 2:57pm

When `loadSystemFonts: true`, the `defaultFontFamily` option can also be omitted.

…ffers`

…llback Previously, resvg-js would not match any fonts in SVG text, even if there were fonts in the OS that could render them. This commit makes it possible to fallback properly. ```js const resvg = new Resvg(svg, { font: { loadSystemFonts: true, defaultFontFamily: 'this-is-a-non-existent-font-family', }, }) ```

* feat: improve custom loaded fonts * feat: refactoring and adding test cases When `loadSystemFonts: true`, the `defaultFontFamily` option can also be omitted. * feat(wasm): support for getting the default font-family from `fontsBuffers` * chore: new example/text.js * feat: the defaultFontFamily is not found in the OS and needs to be fallback Previously, resvg-js would not match any fonts in SVG text, even if there were fonts in the OS that could render them. This commit makes it possible to fallback properly. ```js const resvg = new Resvg(svg, { font: { loadSystemFonts: true, defaultFontFamily: 'this-is-a-non-existent-font-family', }, }) ```

yisibl force-pushed the better-load-custom-font branch from 3a1d771 to bad1e6c Compare February 20, 2023 09:06

vercel bot deployed to Preview February 20, 2023 09:06 View deployment

yisibl force-pushed the better-load-custom-font branch from bad1e6c to 45957fa Compare February 20, 2023 09:08

vercel bot deployed to Preview February 20, 2023 09:08 View deployment

yisibl mentioned this pull request Feb 20, 2023

text is not added when using this library, it works fine when using resvg directly from terminal #210

Closed

yisibl force-pushed the better-load-custom-font branch from 45957fa to 34a27f9 Compare August 6, 2023 09:53

vercel bot deployed to Preview August 6, 2023 09:53 View deployment

yisibl force-pushed the better-load-custom-font branch from 34a27f9 to 381e44f Compare August 6, 2023 09:58

vercel bot deployed to Preview August 6, 2023 09:59 View deployment

vercel bot deployed to Preview August 6, 2023 10:20 View deployment

yisibl force-pushed the better-load-custom-font branch from 0288b9f to ce3a162 Compare August 6, 2023 10:24

vercel bot deployed to Preview August 6, 2023 10:24 View deployment

yisibl added 2 commits August 6, 2023 20:42

feat: improve custom loaded fonts

898db0b

feat: refactoring and adding test cases

d49c695

When `loadSystemFonts: true`, the `defaultFontFamily` option can also be omitted.

yisibl force-pushed the better-load-custom-font branch from ce3a162 to 2c47bb3 Compare August 6, 2023 15:00

vercel bot deployed to Preview August 6, 2023 15:00 View deployment

feat(wasm): support for getting the default font-family from `fontsBu…

eb9ad3a

…ffers`

yisibl force-pushed the better-load-custom-font branch from 2c47bb3 to eb9ad3a Compare August 6, 2023 15:10

vercel bot deployed to Preview August 6, 2023 15:10 View deployment

chore: new example/text.js

d85973b

vercel bot deployed to Preview August 6, 2023 15:44 View deployment

yisibl requested a review from zimond August 6, 2023 15:49

yisibl marked this pull request as ready for review August 6, 2023 15:49

vercel bot deployed to Preview August 7, 2023 12:20 View deployment

yisibl force-pushed the better-load-custom-font branch from d1b8b49 to 5496a80 Compare August 7, 2023 12:23

vercel bot deployed to Preview August 7, 2023 12:23 View deployment

vercel bot deployed to Preview August 7, 2023 13:46 View deployment

yisibl force-pushed the better-load-custom-font branch from 4b6b292 to 2d11a0a Compare August 7, 2023 13:50

yisibl force-pushed the better-load-custom-font branch from 38c7f0e to faa8e82 Compare August 8, 2023 13:17

vercel bot deployed to Preview August 8, 2023 13:17 View deployment

yisibl force-pushed the better-load-custom-font branch from faa8e82 to 9e1ec66 Compare August 8, 2023 13:28

vercel bot deployed to Preview August 8, 2023 13:28 View deployment

yisibl force-pushed the better-load-custom-font branch from 9e1ec66 to c585cd5 Compare August 8, 2023 13:30

vercel bot deployed to Preview August 8, 2023 13:30 View deployment

test4

fc28e1b

yisibl force-pushed the better-load-custom-font branch from c585cd5 to fc28e1b Compare August 8, 2023 13:48

vercel bot deployed to Preview August 8, 2023 13:48 View deployment

vercel bot deployed to Preview August 8, 2023 14:05 View deployment

test5 apt-get install fontconfig

94eb60f

yisibl force-pushed the better-load-custom-font branch from efac61f to 94eb60f Compare August 8, 2023 16:25

vercel bot deployed to Preview August 8, 2023 16:25 View deployment

vercel bot deployed to Preview August 9, 2023 04:04 View deployment

yisibl force-pushed the better-load-custom-font branch from 8ebc6d2 to 0911357 Compare August 9, 2023 07:30

vercel bot deployed to Preview August 9, 2023 07:30 View deployment

yisibl force-pushed the better-load-custom-font branch from 0911357 to 9e0be74 Compare August 20, 2023 14:28

vercel bot deployed to Preview August 20, 2023 14:28 View deployment

yisibl force-pushed the better-load-custom-font branch from 9e0be74 to e01cb8a Compare August 20, 2023 14:30

vercel bot deployed to Preview August 20, 2023 14:30 View deployment

yisibl force-pushed the better-load-custom-font branch from e01cb8a to e193aa6 Compare August 20, 2023 14:33

vercel bot deployed to Preview August 20, 2023 14:33 View deployment

test5: remove fontconfig in CI

07349a6

yisibl force-pushed the better-load-custom-font branch from e193aa6 to 07349a6 Compare August 20, 2023 14:56

vercel bot deployed to Preview August 20, 2023 14:57 View deployment

zimond approved these changes Aug 21, 2023

View reviewed changes

zimond merged commit 8d5cd92 into main Aug 21, 2023
32 checks passed

yisibl deleted the better-load-custom-font branch August 21, 2023 06:49

Ghustavh97 mentioned this pull request Jul 22, 2024

[Snyk] Upgrade @resvg/resvg-js from 2.1.0 to 2.6.2 oslllo/svg2#39

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improve custom loaded fonts #209

feat: improve custom loaded fonts #209

yisibl commented Feb 14, 2023 •

edited

Loading

vercel bot commented Feb 14, 2023 •

edited

Loading

feat: improve custom loaded fonts #209

feat: improve custom loaded fonts #209

Conversation

yisibl commented Feb 14, 2023 • edited Loading

vercel bot commented Feb 14, 2023 • edited Loading

yisibl commented Feb 14, 2023 •

edited

Loading

vercel bot commented Feb 14, 2023 •

edited

Loading