Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to usvg/resvg 0.34 #258

Closed
wants to merge 0 commits into from
Closed

feat: upgrade to usvg/resvg 0.34 #258

wants to merge 0 commits into from

Conversation

zimond
Copy link
Collaborator

@zimond zimond commented Sep 18, 2023 •
edited
Loading

fixes #256
closes #205

@vercel
Copy link

vercel bot commented Sep 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
resvg-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 8:54am

yisibl
yisibl reviewed Sep 18, 2023
View reviewed changes
src/options.rs Outdated
Ok((width, height, transform))
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

由于 resvg 0.33.0 删除了 resvg::FitTo 方法，这里我们进行了重写，需要增加 FitTo height 的测试用例。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在这里完成：#259

@Jackie1210
Copy link

Just curious, why we don't upgrade to 0.35?

@zimond
Copy link
Collaborator Author

zimond commented Sep 19, 2023

@Jackie1210 haha because 0.34 fork is prepared for quite some time. So this PR could quickly catch up with a recent version of resvg. Besides, starting from 0.33, our bbox related apis are broken due to resvg changes, so even if we upgrade to 0.35, this branch could hardly be merged any time soon.

@Jackie1210
Copy link

@zimond Thanks for your patient explanation.

@yisibl
Copy link
Member

yisibl commented Sep 19, 2023

Just curious, why we don't upgrade to 0.35?

@Jackie1210 It depends on this issue: linebender/resvg#662

@Jackie1210 Jackie1210 mentioned this pull request Sep 20, 2023
Closed
@yisibl
Copy link
Member

yisibl commented Sep 20, 2023 •
edited
Loading

Two key APIs that we relied on have been removed in newer versions of resvg.

resvg 0.34.0

  • usvg::NodeExt::calculate_bbox no longer includes stroke bbox.

resvg 0.33.0

  • Removed resvg::FitTo
    @zimond has reimplemented FitTo in this PR.

Perhaps we should upgrade to resvg 0.33.0 just to be safe?

@zimond zimond mentioned this pull request Sep 22, 2023
Closed
@Jackie1210
Copy link

#256 looks fine, but seems stiil render nothing for #257 @zimond

@ppjjzz
Copy link

ppjjzz commented Oct 10, 2023

any update?

@yisibl
Copy link
Member

yisibl commented Oct 12, 2023

any update?

It will be released when it is ready.

@yisibl yisibl closed this Oct 16, 2023
@yisibl yisibl mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yisibl yisibl yisibl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Border render incorrectly on version 2.4.1 Wrong generation into PNG(need support mask-type)
4 participants
@zimond @Jackie1210 @yisibl @ppjjzz