Create systemd cgroup if not present #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanyaEleventhGoddess
force-pushed
the
master
branch
3 times, most recently
from
e5db883 to
794b827
Compare
|
While this is interesting, and I can see how it's useful for the particular use case of running systemd inside a container on a non-systemd host, I'm not sure that this is the appropriate place for it. Frankly, I would love to see alternative init systems like sysvinit embrace setting up cgroups properly so that this "package" (which is really a glorified single |
|
While this is interesting, and I can see how it's useful for the particular use case of running systemd inside a container on a non-systemd host, I'm not sure that this is the appropriate place for it.
Exactly because it's useful it would be really nice if you did that. This package replaces systemd cgroup management during boot, so it would be fair creating his cgroup too :)
Keep in mind that this merge also solves https://bugs.debian.org/950986, it's not JUST about systemd cgroup.
Frankly, I would love to see alternative init systems like sysvinit embrace setting up cgroups properly so that this "package" (which is really a glorified single `for` loop shell script) doesn't need to exist. For example, OpenRC has native support for using them, and I think it provides a lot of value for the thing responsible for scheduling/monitoring processes in the system to be able to provide and control things like resource limits.
This would break UNIX philosophy of keeping one tool for doing one thing, which is exactly why lots of people adopt sysvinit and not openrc, upstart or similar init systems
|
abelbeck
added a commit
to astlinux-project/astlinux
that referenced
this pull request
Aug 22, 2020
** Needs much testing ** ** Not yet for production ** Notable changes: - toolchain, built with kernel 4.19 headers - lxc, update cgroupfs-mount to support cgroup systemd Ref: tianon/cgroupfs-mount#16 - arnofw, tweak for kernels >= 4.19 merged nf_conntrack_ipv{4,6} into nf_conntrack - wireguard, enable kernel udp_tunnel modules - dahdi-linux, version bump to 3.1.0, remove BR2_PACKAGE_DAHDI_HFCS and BR2_PACKAGE_RHINO - dahdi-tools, version bump to 3.1.0 - iproute2, version bump to 4.20.0 - r8168, use native 4.19 kernel driver - tg3, use native 4.19 kernel driver - network bridge, tweak for kernels >= 3.18, not loading br_netfilter avoids filtering - rngd, make CONFIG_HW_RANDOM a module so /dev/hwrng is not created by default (still needs tweaks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables non-systemd distros to host containers/docker images using systemd