Merge pull request #259 from tid-kijyun/fix/cleanup_when_removing_a_node

Fixed cleanup when removing a node
tid-kijyun · Dec 1, 2021 · 73c5e8a · 73c5e8a
2 parents 16f8eb7 + 4c7a9d6
commit 73c5e8a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/Sources/Kanna/libxmlHTMLNode.swift b/Sources/Kanna/libxmlHTMLNode.swift
@@ -193,7 +193,7 @@ final class libxmlHTMLNode: XMLElement {
             return
         }
         xmlUnlinkNode(node.nodePtr)
-        xmlFree(node.nodePtr)
+        xmlFreeNode(node.nodePtr)
     }
 
     private func node(from ptr: xmlNodePtr?) -> XMLElement? {

diff --git a/Tests/KannaTests/KannaHTMLModifyingTests.swift b/Tests/KannaTests/KannaHTMLModifyingTests.swift
@@ -53,6 +53,22 @@ class KannaHTMLModifyingTests: XCTestCase {
             XCTAssert(doc.body!.toHTML == modifyNextHTML)
         }
     }
+
+    func testHTML_RemoveNode() {
+        let html = "<body><div>A love triangle.<h1>Three's Company</h1></div></body>"
+
+        let removedHTML = "<body><div>A love triangle.</div></body>"
+
+        do {
+            guard let doc = try? HTML(html: html, encoding: .utf8),
+                let h1 = doc.at_css("h1") else {
+                    return
+            }
+
+            doc.body?.removeChild(h1)
+            XCTAssert(doc.body!.toHTML == removedHTML)
+        }
+    }
 }
 
 extension KannaHTMLModifyingTests {