[BACK-3125] Add SMART identity provider #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddkazakov
force-pushed
the
tk-smart-auth
branch
from
e7123a7
to
d472499
Compare
lostlevels
approved these changes
Oct 25, 2024
| try { | ||
| SimpleHttp.Response response = request.asResponse(); | ||
| if (response.getStatus() != 200) { | ||
| String msg = "failed to invoke url [" + smartConfigurationUrl + "]"; |
There was a problem hiding this comment.
Should this be the default since the throw new IdentityBrokerException("Failed to invoke url [" + smartConfigurationUrl + "]: " + msg); would produce something like throw new IdentityBrokerException("Failed to invoke url [" + smartConfigurationUrl + "]: " + "failed to invoke url [" + smartConfigurationUrl + "]") - seems like it's just repeating it at that point.
| if (LOG.isTraceEnabled()) { | ||
| IParser parser = ctx.newJsonParser(); | ||
| String serialized = parser.encodeResourceToString(practitioner); | ||
| LOG.tracef("Retrieved practitioner resource: " + serialized); |
There was a problem hiding this comment.
Should this be using an actual string format, LOG.tracef("....%s", serialized) ?
|
|
||
| Practitioner practitioner = getPractitioner(idToken.getSubject(), accessToken); | ||
| for (ContactPoint c : practitioner.getTelecom()) { | ||
| if (c.getSystem() == ContactPoint.ContactPointSystem.EMAIL && c.getValue() != null && !c.getValue().isEmpty()) { |
There was a problem hiding this comment.
Should this use c.getValue().isBlank() instead of c.getValue().isEmpty() - not sure if it can ever be whitespace though.
|
@lostlevels ready for final review |
toddkazakov
force-pushed
the
tk-smart-auth
branch
from
e70c558
to
bbc911a
Compare
lostlevels
previously approved these changes
Oct 29, 2024
toddkazakov
dismissed
lostlevels’s stale review
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.