-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACK-3392] Add OpenID sector for Abbott OAuth #817
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of URLs / data to put in an env variable. I wonder if it shouldn't be a in a file, eventually that is.
As a temporary measure, it seems fine though.
Thanks. Where would we put the file? I'd like to put it in the infrastructure somewhere so it can be easily configured per environment. I'm probably missing something obvious. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/deploy dev1 |
/deploy dev |
toddkazakov updated values.yaml file in dev1 |
toddkazakov updated flux policies file in dev1 |
toddkazakov deployed platform BACK-3392-abbott-sector-identifier branch to dev1 namespace |
Note: This implementation is a temporary placeholder to allow bootstrapping of the Abbott OAuth client workflow. Will need to migrate this to environment variables and add minimal authorization. For now, though, this is acceptable since it isn't revealing anything that is not already available in other locations (i.e. other public repos).
TODO: https://tidepool.atlassian.net/browse/BACK-3394