Code

Simplify escaping strategy#1396

Code

Merged

hadley merged 55 commits intomaintidyverse/dbplyr:mainfrom simplify-escapingtidyverse/dbplyr:simplify-escapingCopy head branch name to clipboardFeb 20, 2024

+673-838

Commits

Commits on Nov 7, 2023

• First stab

  hadley

  committed
  8105d7b

  Copy full SHA for 8105d7b

Commits on Nov 8, 2023

• Merge commit '388a6eef0e634efa693d809061ceac91d3b69a77'

  Show description for fb1e38a
  hadley

  committed
  fb1e38a

  Copy full SHA for fb1e38a

• Fixing alias escaping

  hadley

  committed
  d03a206

  Copy full SHA for d03a206

• Fix argument name

  hadley

  committed
  054ee2b

  Copy full SHA for 054ee2b

• Correct escaping in sql_star()

  hadley

  committed
  892b23e

  Copy full SHA for 892b23e

• Extract table name from id string

  hadley

  committed
  f7a65bc

  Copy full SHA for f7a65bc

• More getting stuff to work

  hadley

  committed
  afa58e9

  Copy full SHA for afa58e9

Commits on Nov 28, 2023

• Restore missing con argument

  hadley

  committed
  f370e12

  Copy full SHA for f370e12

• Making progress on joins

  hadley

  committed
  6ca54e3

  Copy full SHA for 6ca54e3

• Add c method

  hadley

  committed
  3365fe8

  Copy full SHA for 3365fe8

• x_as and y_as are now already escaped

  hadley

  committed
  c520833

  Copy full SHA for c520833

• Escape LHS & RHS names

  hadley

  committed
  9c5ac01

  Copy full SHA for 9c5ac01

• Generate aliases based on table names

  hadley

  committed
  ffd27e8

  Copy full SHA for ffd27e8

• Misc fixes

  hadley

  committed
  381a7ed

  Copy full SHA for 381a7ed

• Ensure unique_query_name() generates esacped name

  hadley

  committed
  d8b66f3

  Copy full SHA for d8b66f3

• Escaping now happens earlier

  hadley

  committed
  2b2c3d2

  Copy full SHA for 2b2c3d2

• Update postgres setup information

  hadley

  committed
  8ec7670

  Copy full SHA for 8ec7670

• Remove old ident code

  hadley

  committed
  68c799c

  Copy full SHA for 68c799c

• Start testing table_name functions

  hadley

  committed
  6889d45

  Copy full SHA for 6889d45

• Merged origin/main into simplify-escaping

  hadley

  committed
  73d9628

  Copy full SHA for 73d9628

• Rename constructor

  hadley

  committed
  90bc9a1

  Copy full SHA for 90bc9a1

Commits on Nov 29, 2023

• Reorganise table-name file

  hadley

  committed
  fa83a18

  Copy full SHA for fa83a18

• Fix R CMD check issues

  hadley

  committed
  8ae7399

  Copy full SHA for 8ae7399

• Move as and is functions closer & test together

  hadley

  committed
  0048df6

  Copy full SHA for 0048df6

• More explaining & re-organising

  hadley

  committed
  2ef6fba

  Copy full SHA for 2ef6fba

• Make as_table_name() stricter

  Show description for 07aee8e
  hadley

  committed
  07aee8e

  Copy full SHA for 07aee8e

• Test more methods; fix test

  hadley

  committed
  90ee786

  Copy full SHA for 90ee786

Commits on Nov 30, 2023

• Update old function

  hadley

  committed
  0baaf3c

  Copy full SHA for 0baaf3c

• Tweak argument checking to hopefully fix problems on older R

  hadley

  committed
  fbc23aa

  Copy full SHA for fbc23aa

• Simplify code; keep question

  hadley

  committed
  a749f3c

  Copy full SHA for a749f3c

• WS

  hadley

  committed
  2252c79

  Copy full SHA for 2252c79

Commits on Dec 1, 2023

• Update temporary table prefix

  hadley

  committed
  0ebc70f

  Copy full SHA for 0ebc70f

• Add table name check

  hadley

  committed
  5024363

  Copy full SHA for 5024363

• Implement check_table_name()

  Show description for 12f682f
  hadley

  committed
  12f682f

  Copy full SHA for 12f682f

• unique_subquery_name() no longer needs con

  hadley

  committed
  bff0130

  Copy full SHA for bff0130

Commits on Dec 18, 2023

• Coerce rather than checking

  hadley

  committed
  e7bef90

  Copy full SHA for e7bef90

• RPostgreSQL needs unquoted table name

  hadley

  committed
  ac051f7

  Copy full SHA for ac051f7

• Disable windows R3.6 checking for RMariaDB

  hadley

  committed
  b8e9b62

  Copy full SHA for b8e9b62

• Use correct function name

  hadley

  committed
  7ddea50

  Copy full SHA for 7ddea50

• Refine table_name_table() interface

  hadley

  committed
  86aeea5

  Copy full SHA for 86aeea5

• Teach S4 that dbplyr_table_name inherits from character

  hadley

  committed
  af52e5e

  Copy full SHA for af52e5e

• Move coercion back to methods

  Show description for fd5eaec
  hadley

  committed
  fd5eaec

  Copy full SHA for fd5eaec

Commits on Jan 22, 2024

• Merge commit '781d630b3ae059e7e8f2176c7261a48ba17a53d3'

  mgirlich

  committed
  177af83

  Copy full SHA for 177af83

• Use dev odbc for testing MS SQL

  mgirlich

  committed
  dd2d0c3

  Copy full SHA for dd2d0c3

Commits on Jan 31, 2024

• Remove remote odbc and require >= 1.4.2 instead

  mgirlich

  committed
  2e83a36

  Copy full SHA for 2e83a36

Commits on Feb 14, 2024

• Update R/lazy-join-query.R

  Show description for 6c3c2a6
  

  hadley

  and

  mgirlich

  authored
  6c3c2a6

  Copy full SHA for 6c3c2a6

• sql_table_name_prefix() improvements

  Show description for 091b04f
  hadley

  committed
  091b04f

  Copy full SHA for 091b04f

• Make c() safer

  hadley

  committed
  b85ca5d

  Copy full SHA for b85ca5d

Commits on Feb 15, 2024

• Handle unquoting within in_schema/in_catalog

  hadley

  committed
  a434eb0

  Copy full SHA for a434eb0

• Uncomment accidentally commented tests

  hadley

  committed
  09e78e7

  Copy full SHA for 09e78e7

• Qualify is

  hadley

  committed
  2cc65f3

  Copy full SHA for 2cc65f3

• Add bullet about index name

  hadley

  committed
  c28dd74

  Copy full SHA for c28dd74

• Rename table_name to table_path

  hadley

  committed
  c88c355

  Copy full SHA for c88c355

• Add news bullets

  hadley

  committed
  27a789f

  Copy full SHA for 27a789f

• Merged origin/main into simplify-escaping

  hadley

  committed
  261b3d6

  Copy full SHA for 261b3d6