Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 路肩退避のMRMの表示に対応する #104

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Jun 26, 2024

Related Issue(required)

Description(required)

MRMに路肩退避が追加されたのでこのときもCONFORTABLE STOPと同じ表示をするようにしました
また、external signageに不要なファイルとstand alone modeのときにserviceでの指示になっていなかったので修正しました

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@yabuta yabuta requested a review from tkhmy June 26, 2024 03:31
Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yabuta yabuta merged commit f5d8ac6 into develop Jun 26, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants