Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/seperate fms and negative distance #134

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

tkhmy
Copy link
Contributor

@tkhmy tkhmy commented Nov 5, 2024

Related Issue(required)

Description(required)

こちらを2.4.2へcherry pickします
#130
#131

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@yabuta
Copy link
Collaborator

yabuta commented Nov 5, 2024

@tkhmy beta/v2.4.1へ出すように変更できますか?

@tkhmy tkhmy changed the base branch from beta/v2.4.0 to beta/v2.4.1 November 5, 2024 04:41
tkhmy added 2 commits November 5, 2024 13:42
* seperate fms client

Signed-off-by: tkhmy <[email protected]>

* add ignore disconnect

Signed-off-by: tkhmy <[email protected]>

* remove some colcon build warning

Signed-off-by: tkhmy <[email protected]>

* change naming

Signed-off-by: tkhmy <[email protected]>

* change time out, minor fix

Signed-off-by: tkhmy <[email protected]>

* remove old logger

Signed-off-by: tkhmy <[email protected]>

* fix

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>
@tkhmy tkhmy force-pushed the hotfix/seperate_fms_and_negative_distance branch from 243eadd to 1f2a8e6 Compare November 5, 2024 04:42
@tkhmy
Copy link
Contributor Author

tkhmy commented Nov 5, 2024

@yabuta
修正しました。

@tkhmy tkhmy requested a review from yabuta November 5, 2024 05:03
Signed-off-by: tkhmy <[email protected]>
@tkhmy tkhmy merged commit c5f3202 into beta/v2.4.1 Nov 8, 2024
0 of 2 checks passed
@tkhmy tkhmy deleted the hotfix/seperate_fms_and_negative_distance branch November 8, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants