Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: サイネージの生存判定のためdiagnosticを出力する #85

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Dec 21, 2023

Related Issue(required)

Description(required)

サイネージの生存判定のため1Hzでheartbeatのdiagを出力する

header:
  stamp:
    sec: 1703125968
    nanosec: 535917626
  frame_id: ''
status:
- level: "\0"
  name: 'signage: /system/signage_connection : signage heartbeat'
  message: signage is working
  hardware_id: none
  values: []

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@yabuta yabuta changed the title feat: サイネージの生存判定のためdiagnosticwo feat: サイネージの生存判定のためdiagnosticを出力する Dec 21, 2023
@yabuta yabuta requested a review from tkhmy December 21, 2023 02:36
@yabuta yabuta marked this pull request as ready for review December 25, 2023 05:33
Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yabuta yabuta merged commit 64a8eca into develop Dec 27, 2023
1 of 2 checks passed
@yabuta yabuta deleted the freature/heartbeat_diag branch February 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants