-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 音声をON/OFF切り替える設定を追加 #88
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* do not announce emergency when stop mode! (#81) * do not announce emergency when stop mode! Signed-off-by: tkhmy <[email protected]> * fix Signed-off-by: tkhmy <[email protected]> * fix Signed-off-by: tkhmy <[email protected]> --------- Signed-off-by: tkhmy <[email protected]> * add mute timeout for engage (#82) Signed-off-by: tkhmy <[email protected]> --------- Signed-off-by: tkhmy <[email protected]> Co-authored-by: Kah Hooi Tan <[email protected]>
feat: add service for setting announce volume
feat: サイネージの生存判定のためdiagnosticを出力する
feat: Autoware切断時の表示を追加
chore: diagnostic updaterがpackage.xmlになかったので追加
tkhmy
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit b06dc27.
すみません、間違えてdevelopをマージしてしまってうまく戻せなかったのでブランチを作成し直します |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(required)
Description(required)
音声ごとに発声するかどうかを選択できるフラグを追加しました
同時に利用していなかった音声ファイルを削除しました
また、走行中の再発進のときのフラグはrestart_engageに変更しました
Review Procedure(required)
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.