Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 音声のON/OFFを切り替える設定を追加 #90

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Jan 29, 2024

Related Issue(required)

Description(required)

音声ごとに発声するかどうかを選択できるフラグを追加しました
同時に利用していなかった音声ファイルを削除しました
また、走行中の再発進のときのフラグはrestart_engageに変更しました

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@yabuta yabuta requested a review from tkhmy January 29, 2024 04:37
@yabuta
Copy link
Collaborator Author

yabuta commented Jan 29, 2024

@tkhmy すみません、前のPRがぐちゃぐちゃになったので出し直しました
内容は変えてないですが確認できたらApproveお願いします

Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yabuta yabuta merged commit 630b15a into beta/v2.2.1 Jan 29, 2024
0 of 4 checks passed
@yabuta yabuta deleted the feature/sound_on/off_parameter branch February 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants