fix(intrinsic_camera_calibrator): fixed dot board detector #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
knzo25
added a commit
that referenced
this pull request
Sep 10, 2024
* chore: adapted to the new way of using lidartag Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: rename decompressed_topic name to avoid name conflict on live Signed-off-by: Manato HIRABAYASHI <[email protected]> * feat: introduce `choice` for bool options Signed-off-by: Manato HIRABAYASHI <[email protected]> * fix: init tf tree visualization (#188) * fix: init tf tree visualization Signed-off-by: vividf <[email protected]> * chore: fix error Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]> * fix(intrinsic_camera_calibrator): fixed dot board detector (#189) fix: forgot to add a fix to the dot board detector Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> Signed-off-by: Manato HIRABAYASHI <[email protected]> Signed-off-by: vividf <[email protected]> Co-authored-by: Kenzo Lobos-Tsunekawa <[email protected]> Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]>
knzo25
added a commit
that referenced
this pull request
Sep 24, 2024
* chore: changed the folder structure following the removal of non sensor related packages Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * add indefinite article Signed-off-by: vividf <[email protected]> * fix camera info explanation Signed-off-by: vividf <[email protected]> * fix kalman filter Signed-off-by: vividf <[email protected]> * fix sentence Signed-off-by: vividf <[email protected]> * fix capital Signed-off-by: vividf <[email protected]> * fix more sentence Signed-off-by: vividf <[email protected]> * fix description Signed-off-by: vividf <[email protected]> * fix background model Signed-off-by: vividf <[email protected]> * add more explaination for marker package Signed-off-by: vividf <[email protected]> * fix lidartag, apriltag Signed-off-by: vividf <[email protected]> * fixed camera_info Signed-off-by: vividf <[email protected]> * fix Final TF tree description Signed-off-by: vividf <[email protected]> * fix plural Signed-off-by: vividf <[email protected]> * add more explanation Signed-off-by: vividf <[email protected]> * grammar fix Signed-off-by: vividf <[email protected]> * fix sentence Signed-off-by: vividf <[email protected]> * clarify some sentences Signed-off-by: vividf <[email protected]> * fix sentence Signed-off-by: vividf <[email protected]> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * fix related link Signed-off-by: vividf <[email protected]> * add more explanation Signed-off-by: vividf <[email protected]> * add more explanation to marker docs and tutorial Signed-off-by: vividf <[email protected]> * add more explanation for mapping based docs and tutorial Signed-off-by: vividf <[email protected]> * fix some previous error Signed-off-by: vividf <[email protected]> * fix section Signed-off-by: vividf <[email protected]> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * fix word Signed-off-by: vividf <[email protected]> * fix from True to true Signed-off-by: vividf <[email protected]> * add correct unit Signed-off-by: vividf <[email protected]> * fix radar description Signed-off-by: vividf <[email protected]> * fix topic description Signed-off-by: vividf <[email protected]> * add addtional line Signed-off-by: vividf <[email protected]> * fix service description Signed-off-by: vividf <[email protected]> * seperate text in step4 Signed-off-by: vividf <[email protected]> * fix background model timeout description Signed-off-by: vividf <[email protected]> * fix min_foreground_points Signed-off-by: vividf <[email protected]> * fix sentence Signed-off-by: vividf <[email protected]> * add explanation for radar foreground figure Signed-off-by: vividf <[email protected]> * change to plural Signed-off-by: vividf <[email protected]> * lidar cluster and blue points explanation Signed-off-by: vividf <[email protected]> * add radar resolution limitation Signed-off-by: vividf <[email protected]> * fix pro tips Signed-off-by: vividf <[email protected]> * fix known limitation Signed-off-by: vividf <[email protected]> * fix initial calibration error explanation Signed-off-by: vividf <[email protected]> * add BEV enviroment Signed-off-by: vividf <[email protected]> * add vis image for mapping based Signed-off-by: vividf <[email protected]> * change to svg file Signed-off-by: vividf <[email protected]> * fix errors Signed-off-by: vividf <[email protected]> * add resolution explaination Signed-off-by: vividf <[email protected]> * fix lidar to camera Signed-off-by: vividf <[email protected]> * remove last point Signed-off-by: vividf <[email protected]> * seperate the context Signed-off-by: vividf <[email protected]> * remove accurately Signed-off-by: vividf <[email protected]> * remove addtional the Signed-off-by: vividf <[email protected]> * add link Signed-off-by: vividf <[email protected]> * fix message to object and add reason of reliably detecting challenge Signed-off-by: vividf <[email protected]> * fix section 2 Signed-off-by: vividf <[email protected]> * improve step 3 Signed-off-by: vividf <[email protected]> * fix calibration camera Signed-off-by: vividf <[email protected]> * add docker solution Signed-off-by: vividf <[email protected]> * fix some sentences in mapping_based Signed-off-by: vividf <[email protected]> * fix the input parameters Signed-off-by: vividf <[email protected]> * ci(pre-commit): autofix * chore: applied changes from the auto messages migration note: this was note made as another PR since it also involved documentation Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: mispells Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: another attempt to fix the mispell Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: forgot to commit one .repos file Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: replaced private links for public ones Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: fix input Signed-off-by: vividf <[email protected]> * chore: fix the FAQ Signed-off-by: vividf <[email protected]> * chore: fix radar purpose Signed-off-by: vividf <[email protected]> * predict to estimate Signed-off-by: vividf <[email protected]> * chore: fix radar vis image Signed-off-by: vividf <[email protected]> * chore: fix foreground extraction Signed-off-by: vividf <[email protected]> * chore: fix radar step 3 explaination Signed-off-by: vividf <[email protected]> * chore: fix add_lidar_radar_pair parameter explanation Signed-off-by: vividf <[email protected]> * chore: fix radar Pro tips/recommendations Signed-off-by: vividf <[email protected]> * chore: fix radar foreground pointcloud Signed-off-by: vividf <[email protected]> * chore: replace the pnp lidar pos to correct one Signed-off-by: vividf <[email protected]> * chore: fix didn't to did not Signed-off-by: vividf <[email protected]> * chore: fix tag pos explanation Signed-off-by: vividf <[email protected]> * chore: remove some text Signed-off-by: vividf <[email protected]> * chore: fix some sentence of mapping Signed-off-by: vividf <[email protected]> * chore: add radar foreground and background image and explanation Signed-off-by: vividf <[email protected]> * chore: fix parameter desciption Signed-off-by: vividf <[email protected]> * chore: fix larger to exceed Signed-off-by: vividf <[email protected]> * chore: fix grammar errors in mapping based calibrator Signed-off-by: vividf <[email protected]> * chore: fix grammar errors in marker based calibrator Signed-off-by: vividf <[email protected]> * chore: fixed ci/cd Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: ci/cd part 2 Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: moved meta package's path Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: changed private repo to oss one Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: Update calibrators/marker_radar_lidar_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * chore: fix marker calibrator algorithms explanation Signed-off-by: vividf <[email protected]> * chore: add calibration process Signed-off-by: vividf <[email protected]> * chore: remove first Signed-off-by: vividf <[email protected]> * chore: fix grammar Signed-off-by: vividf <[email protected]> * chore: remove finalize Signed-off-by: vividf <[email protected]> * chore: fix Z to z Signed-off-by: vividf <[email protected]> * chore: specify yaw rotation Signed-off-by: vividf <[email protected]> * chore: fix all of the explanation for output parameters Signed-off-by: vividf <[email protected]> * chore: change predictable Signed-off-by: vividf <[email protected]> * chore: remove redundant calibration area Signed-off-by: vividf <[email protected]> * fix pro tips Signed-off-by: vividf <[email protected]> * chore: change to calibrating Signed-off-by: vividf <[email protected]> * chore: fix more grammar errors Signed-off-by: vividf <[email protected]> * chore: add more info for the radar foreground image Signed-off-by: vividf <[email protected]> * chore: add explanation for estimation algorithm Signed-off-by: vividf <[email protected]> * chore: add svd explanation Signed-off-by: vividf <[email protected]> * chore: fix radar reflector explanation Signed-off-by: vividf <[email protected]> * chore: remove while Signed-off-by: vividf <[email protected]> * chore: remove angle Signed-off-by: vividf <[email protected]> * chore: fix mapping errors Signed-off-by: vividf <[email protected]> * chore: update calibrators/marker_radar_lidar_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * chore: fix grammar Signed-off-by: vividf <[email protected]> * chore: fix radar pro tips Signed-off-by: vividf <[email protected]> * chore: update calibrators/tag_based_pnp_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * chore: add pnp known issues Signed-off-by: vividf <[email protected]> * chore: fix grammar error, pnp overall calibration env Signed-off-by: vividf <[email protected]> * chore: fix grammar error: that Signed-off-by: vividf <[email protected]> * chore: fix pnp FAQ Signed-off-by: vividf <[email protected]> * chore: add the Signed-off-by: vividf <[email protected]> * chore: reflectors's tracks Signed-off-by: vividf <[email protected]> * chore: build to mount Signed-off-by: vividf <[email protected]> * chore: fix final step Signed-off-by: vividf <[email protected]> * chore: add comma Signed-off-by: vividf <[email protected]> * fix: fix radar foreground points to object Signed-off-by: vividf <[email protected]> * chore: remove that is Signed-off-by: vividf <[email protected]> * chore: fix denote as Signed-off-by: vividf <[email protected]> * chore: add explanation for step 4 Signed-off-by: vividf <[email protected]> * chore: fix services Signed-off-by: vividf <[email protected]> * chore: fix radar parallel frame Signed-off-by: vividf <[email protected]> * chore: fix transformation type Signed-off-by: vividf <[email protected]> * chore: add unit1 Signed-off-by: vividf <[email protected]> * chore: add unit2 Signed-off-by: vividf <[email protected]> * chore: no reflector, person, ... Signed-off-by: vividf <[email protected]> * chore: imperfect to inaccuarate Signed-off-by: vividf <[email protected]> * chore: fix object_raw Signed-off-by: vividf <[email protected]> * chore: fix and to or Signed-off-by: vividf <[email protected]> * chore: fix show like sentence Signed-off-by: vividf <[email protected]> * chore: fix link, not in comment Signed-off-by: vividf <[email protected]> * chore: add explanation for radar foreground Signed-off-by: vividf <[email protected]> * chore: fix add lidar-radar pair Signed-off-by: vividf <[email protected]> * chore: fix blue point explanation Signed-off-by: vividf <[email protected]> * chore: explain two radar , one lidar Signed-off-by: vividf <[email protected]> * chore: line to curve Signed-off-by: vividf <[email protected]> * chore: change coordinate to frame Signed-off-by: vividf <[email protected]> * chore: add explanation for ground segmentation in radar-lidar calibrator Signed-off-by: vividf <[email protected]> * chore: add ground segmentation model Signed-off-by: vividf <[email protected]> * chore: fixed compilations issues due to changes in universe Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: colcon ignored the tunable tf package since it produces build errors and is not being maintained Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: attepting to update ci/cd since it seemed old and it was failing Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: removed galactic from ci/cd since it is unsupported and was still part of our ci/cd Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: fixed missing cpell ignores Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: fix mapping calibrator Signed-off-by: vividf <[email protected]> * fix: fix spell check Signed-off-by: vividf <[email protected]> * fix: fix grammar errors Signed-off-by: vividf <[email protected]> * fix: fix mapping section Signed-off-by: vividf <[email protected]> * fix: fix errors Signed-off-by: vividf <[email protected]> * fix: fix grammar error Signed-off-by: vividf <[email protected]> * fix: fix parameters spell check Signed-off-by: vividf <[email protected]> * chore: remove the redundant line Signed-off-by: vividf <[email protected]> * chore: fix central to center Signed-off-by: vividf <[email protected]> * chore: add between sensors Signed-off-by: vividf <[email protected]> * chore: fix grids to grid Signed-off-by: vividf <[email protected]> * chore: fix transformation type explanation Signed-off-by: vividf <[email protected]> * chore: fix rigid transformation estimation Signed-off-by: vividf <[email protected]> * chore: add additional explanation Signed-off-by: vividf <[email protected]> * chore: remove processes Signed-off-by: vividf <[email protected]> * chore: change pinpoint to estiamte Signed-off-by: vividf <[email protected]> * chore: fix topic name Signed-off-by: vividf <[email protected]> * chore: fix doesn't to does not Signed-off-by: vividf <[email protected]> * chore: add more explanation to radar parallel frame Signed-off-by: vividf <[email protected]> * chore: fix topic Signed-off-by: vividf <[email protected]> * chore: unify radar parallel frame and clarify z component Signed-off-by: vividf <[email protected]> * Update calibrators/docs/tutorials/marker_radar_lidar_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * Update calibrators/docs/tutorials/tag_based_pnp_calibrator.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * Update calibrators/marker_radar_lidar_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * chore: fix grammar error Signed-off-by: vividf <[email protected]> * chore: fix at which Signed-off-by: vividf <[email protected]> * chore: add in seconds unit Signed-off-by: vividf <[email protected]> * chore: fix max_no_observation_time Signed-off-by: vividf <[email protected]> * chore: fix new_hypothesis_distance Signed-off-by: vividf <[email protected]> * chore: fix to degrees Signed-off-by: vividf <[email protected]> * chore: fix all square issues Signed-off-by: vividf <[email protected]> * chore: fix lowercase Signed-off-by: vividf <[email protected]> * chore: ARS408 radars Signed-off-by: vividf <[email protected]> * chore: add missing the Signed-off-by: vividf <[email protected]> * chore: fix input_lidar_pointcloud Signed-off-by: vividf <[email protected]> * chore: fix layout Signed-off-by: vividf <[email protected]> * chore: fix more layout Signed-off-by: vividf <[email protected]> * chore: fix sentences Signed-off-by: vividf <[email protected]> * chore: fix in rviz Signed-off-by: vividf <[email protected]> * chore: fix grammar error: of Signed-off-by: vividf <[email protected]> * chore: move butoon out Signed-off-by: vividf <[email protected]> * chore: radar_foreground_pointcloud Signed-off-by: vividf <[email protected]> * chore: remove quotation marks Signed-off-by: vividf <[email protected]> * fix: fix mapping based Signed-off-by: vividf <[email protected]> * chore: fix more grammar error Signed-off-by: vividf <[email protected]> * Update calibrators/marker_radar_lidar_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * chore: fix all rviz Signed-off-by: vividf <[email protected]> * chore: fix unit Signed-off-by: vividf <[email protected]> * chore: fix detections Signed-off-by: vividf <[email protected]> * chore: fix ARS Signed-off-by: vividf <[email protected]> * chore: fix like below Signed-off-by: vividf <[email protected]> * chore: fix uppercase Signed-off-by: vividf <[email protected]> * chore: fix context in mapping Signed-off-by: vividf <[email protected]> * chore: remove some text Signed-off-by: vividf <[email protected]> * chore: fix some grammar Signed-off-by: vividf <[email protected]> * Update calibrators/mapping_based_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * Update calibrators/mapping_based_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * Update calibrators/mapping_based_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * chore: fix spell error Signed-off-by: vividf <[email protected]> * Update calibrators/mapping_based_calibrator/README.md Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * chore: fix link Signed-off-by: vividf <[email protected]> * chore: fix known issues grammar Signed-off-by: vividf <[email protected]> * chore: known issues grammar error2 Signed-off-by: vividf <[email protected]> * chore: tips for distortion Signed-off-by: vividf <[email protected]> * chore: fix all base_link Signed-off-by: vividf <[email protected]> * chore: fix step 2 Signed-off-by: vividf <[email protected]> * chore: dense_pointcloud_num_keyframes plural fix Signed-off-by: vividf <[email protected]> * chore: for developers Signed-off-by: vividf <[email protected]> * chore: keyframe markers and the Signed-off-by: vividf <[email protected]> * chore: extracted from Signed-off-by: vividf <[email protected]> * chore: remove () Signed-off-by: vividf <[email protected]> * chore: add pro-tips Signed-off-by: vividf <[email protected]> * chore: fix step 2 calibration data preparation Signed-off-by: vividf <[email protected]> * chore: add processing Signed-off-by: vividf <[email protected]> * chore: fix data selection Signed-off-by: vividf <[email protected]> * chore: fix more data selection Signed-off-by: vividf <[email protected]> * chore: would be to identical Signed-off-by: vividf <[email protected]> * chore: could get to obtain Signed-off-by: vividf <[email protected]> * fix: fixed dependencies (due to autoware's autoware prefix) Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: moved the sensor calibrator manager outside of the calibrators folder (other changes are pre-commit induced) Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: updated the use of the kalman filter implementation since it was moved into the autoware namespace Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * fix: updated the use of the decompressor Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: adapted to the new way of using lidartag Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * fix: init tf tree visualization (#188) * fix: init tf tree visualization Signed-off-by: vividf <[email protected]> * chore: fix error Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]> * fix(intrinsic_camera_calibrator): fixed dot board detector (#189) fix: forgot to add a fix to the dot board detector Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * docs: candidate for the final documentation of the new api Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: fixed dead links and spelling Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: fixed missing mispell in a package name Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: fixed missing dead link Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> Signed-off-by: vividf <[email protected]> Co-authored-by: vividf <[email protected]> Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
knzo25
added a commit
that referenced
this pull request
Sep 24, 2024
* chore: adapted to the new way of using lidartag Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: rename decompressed_topic name to avoid name conflict on live Signed-off-by: Manato HIRABAYASHI <[email protected]> * feat: introduce `choice` for bool options Signed-off-by: Manato HIRABAYASHI <[email protected]> * fix: init tf tree visualization (#188) * fix: init tf tree visualization Signed-off-by: vividf <[email protected]> * chore: fix error Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]> * fix(intrinsic_camera_calibrator): fixed dot board detector (#189) fix: forgot to add a fix to the dot board detector Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> Signed-off-by: Manato HIRABAYASHI <[email protected]> Signed-off-by: vividf <[email protected]> Co-authored-by: Kenzo Lobos-Tsunekawa <[email protected]> Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dot board detector entered into a deadlock-like state when no board was present
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.