Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: edge auto #190

Merged
merged 7 commits into from
Sep 10, 2024
Merged

Conversation

manato
Copy link

@manato manato commented Sep 10, 2024

Description

This PR aims to update the feature/edge_auto branch on the CalibrationTools repository so that users can enjoy recent update of the tools.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

knzo25 and others added 7 commits September 3, 2024 15:24
…nto feature/edge_auto

Signed-off-by: Manato HIRABAYASHI <[email protected]>
* fix: init tf tree visualization

Signed-off-by: vividf <[email protected]>

* chore: fix error

Signed-off-by: vividf <[email protected]>

---------

Signed-off-by: vividf <[email protected]>
fix: forgot to add a fix to the dot board detector

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25 knzo25 merged commit a71b965 into tier4:feature/edge_auto Sep 10, 2024
3 of 6 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/edge_auto@3e56069). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ra_calibrator/board_detectors/dotboard_detector.py 0.00% 3 Missing ⚠️
..._calibration_manager/sensor_calibration_manager.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             feature/edge_auto    #190   +/-   ##
===================================================
  Coverage                     ?   7.49%           
===================================================
  Files                        ?     104           
  Lines                        ?    7127           
  Branches                     ?     813           
===================================================
  Hits                         ?     534           
  Misses                       ?    6592           
  Partials                     ?       1           
Flag Coverage Δ
differential 7.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

knzo25 added a commit that referenced this pull request Sep 24, 2024
* chore: adapted to the new way of using lidartag

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: rename decompressed_topic name to avoid name conflict on live

Signed-off-by: Manato HIRABAYASHI <[email protected]>

* feat: introduce `choice` for bool options

Signed-off-by: Manato HIRABAYASHI <[email protected]>

* fix: init tf tree visualization (#188)

* fix: init tf tree visualization

Signed-off-by: vividf <[email protected]>

* chore: fix error

Signed-off-by: vividf <[email protected]>

---------

Signed-off-by: vividf <[email protected]>

* fix(intrinsic_camera_calibrator): fixed dot board detector (#189)

fix: forgot to add a fix to the dot board detector

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Manato HIRABAYASHI <[email protected]>
Signed-off-by: vividf <[email protected]>
Co-authored-by: Kenzo Lobos-Tsunekawa <[email protected]>
Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants