Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed the pre-commit issues discovered in #201 #203

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Oct 15, 2024

Description

Fixed the pre-commit issues found in #201

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (bab5400) to head (d17edeb).
Report is 19 commits behind head on tier4/universe.

Files with missing lines Patch % Lines
...calibrator/src/filters/object_detection_filter.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           tier4/universe    #203      +/-   ##
=================================================
- Coverage            0.93%   0.00%   -0.94%     
=================================================
  Files                 270      71     -199     
  Lines               21339    7879   -13460     
  Branches              383     777     +394     
=================================================
- Hits                  200       0     -200     
+ Misses              20982    7879   -13103     
+ Partials              157       0     -157     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knzo25
Copy link
Collaborator Author

knzo25 commented Oct 15, 2024

The remaining errors are from packages to be deprecated in #202

@knzo25 knzo25 merged commit 674cf19 into tier4:tier4/universe Oct 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants