-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
changed the title
Add topic state monitor
feat: add topic state monitor for sensors
Mar 25, 2024
TomohitoAndo
changed the title
feat: add topic state monitor for sensors
feat: add topic state monitor for camera, radar, gnss and imu
Mar 25, 2024
From the perspective of processing load, please consider making it a composal node and launching it from *.launch.py. |
Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
changed the title
feat: add topic state monitor for camera, radar, gnss and imu
feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu
Mar 26, 2024
Signed-off-by: Tomohito Ando <[email protected]>
0x126
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0x126
pushed a commit
that referenced
this pull request
Jul 2, 2024
…and imu (#227) * feat: add topic state monitor for sensors Signed-off-by: Tomohito Ando <[email protected]> * fix comments Signed-off-by: Tomohito Ando <[email protected]> * replace launch.xml with launch.py Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix * add copyright Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kotaro-hihara
pushed a commit
that referenced
this pull request
Aug 27, 2024
…and imu (#227) * feat: add topic state monitor for sensors Signed-off-by: Tomohito Ando <[email protected]> * fix comments Signed-off-by: Tomohito Ando <[email protected]> * replace launch.xml with launch.py Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix * add copyright Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kotaro-hihara
added a commit
that referenced
this pull request
Aug 27, 2024
* feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu (#227) * feat: add topic state monitor for sensors Signed-off-by: Tomohito Ando <[email protected]> * fix comments Signed-off-by: Tomohito Ando <[email protected]> * replace launch.xml with launch.py Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix * add copyright Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * remove topic_state_monitor for camera * feat: add imu_monitor and dummy diag (#212) --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Hiroki OTA <[email protected]>
TomohitoAndo
added a commit
that referenced
this pull request
Aug 30, 2024
* feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu (#227) * feat: add topic state monitor for sensors Signed-off-by: Tomohito Ando <[email protected]> * fix comments Signed-off-by: Tomohito Ando <[email protected]> * replace launch.xml with launch.py Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix * add copyright Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * remove topic_state_monitor for camera * feat: add imu_monitor and dummy diag (#212) --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Hiroki OTA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the topic state monitor for following sensors.
I confirmed diagnostics message was published properly.
Please see the ticket (TIER IV INTERNAL) for the details.
Related Links
Jira: TIER IV INTERNAL