Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu #227

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Mar 25, 2024

Description

This PR adds the topic state monitor for following sensors.

  • Camera 0~7
  • Radar front_center, front_left, front_right, rear_center, rear_left, rear_right
  • GNSS
  • IMU

I confirmed diagnostics message was published properly.
Please see the ticket (TIER IV INTERNAL) for the details.
image

Related Links

Jira: TIER IV INTERNAL

Signed-off-by: Tomohito Ando <[email protected]>
@TomohitoAndo TomohitoAndo changed the title Add topic state monitor feat: add topic state monitor for sensors Mar 25, 2024
@TomohitoAndo TomohitoAndo changed the title feat: add topic state monitor for sensors feat: add topic state monitor for camera, radar, gnss and imu Mar 25, 2024
@TomohitoAndo TomohitoAndo requested review from mkuri, 0x126 and saka1-s March 25, 2024 09:35
@0x126
Copy link
Contributor

0x126 commented Mar 26, 2024

From the perspective of processing load, please consider making it a composal node and launching it from *.launch.py.
https://github.com/tier4/aip_launcher/blob/tier4/universe/aip_x1_launch/launch/topic_state_monitor.launch.py

@TomohitoAndo TomohitoAndo changed the title feat: add topic state monitor for camera, radar, gnss and imu feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu Mar 26, 2024
Signed-off-by: Tomohito Ando <[email protected]>
@TomohitoAndo
Copy link
Contributor Author

@0x126

From the perspective of processing load, please consider making it a composal node and launching it from *.launch.py.

Addressed on 722a4c0
I confirmed this works as expected on logging simulator.

image

Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit 6abf786 into beta/x2/v3.0.0 Mar 26, 2024
10 of 11 checks passed
@TomohitoAndo TomohitoAndo deleted the add-topic-state-monitor branch March 26, 2024 07:54
0x126 pushed a commit that referenced this pull request Jul 2, 2024
…and imu (#227)

* feat: add topic state monitor for sensors

Signed-off-by: Tomohito Ando <[email protected]>

* fix comments

Signed-off-by: Tomohito Ando <[email protected]>

* replace launch.xml with launch.py

Signed-off-by: Tomohito Ando <[email protected]>

* ci(pre-commit): autofix

* add copyright

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kotaro-hihara pushed a commit that referenced this pull request Aug 27, 2024
…and imu (#227)

* feat: add topic state monitor for sensors

Signed-off-by: Tomohito Ando <[email protected]>

* fix comments

Signed-off-by: Tomohito Ando <[email protected]>

* replace launch.xml with launch.py

Signed-off-by: Tomohito Ando <[email protected]>

* ci(pre-commit): autofix

* add copyright

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kotaro-hihara added a commit that referenced this pull request Aug 27, 2024
* feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu (#227)

* feat: add topic state monitor for sensors

Signed-off-by: Tomohito Ando <[email protected]>

* fix comments

Signed-off-by: Tomohito Ando <[email protected]>

* replace launch.xml with launch.py

Signed-off-by: Tomohito Ando <[email protected]>

* ci(pre-commit): autofix

* add copyright

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* remove topic_state_monitor for camera

* feat: add imu_monitor and dummy diag (#212)

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <[email protected]>
TomohitoAndo added a commit that referenced this pull request Aug 30, 2024
* feat(aip_x2_launch): add topic state monitor for camera, radar, gnss and imu (#227)

* feat: add topic state monitor for sensors

Signed-off-by: Tomohito Ando <[email protected]>

* fix comments

Signed-off-by: Tomohito Ando <[email protected]>

* replace launch.xml with launch.py

Signed-off-by: Tomohito Ando <[email protected]>

* ci(pre-commit): autofix

* add copyright

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* remove topic_state_monitor for camera

* feat: add imu_monitor and dummy diag (#212)

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants