Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aip_launcher): add autoware prefix to vehicle_velocity_converter #319

Conversation

a-maumau
Copy link
Contributor

Description

This PR will add the autoware prefix to vehicle_velocity_converter due to the changes in autowarefoundation/autoware.universe#8967 .

Signed-off-by: a-maumau <[email protected]>
@YamatoAndo
Copy link
Contributor

@kimurariku Could you please review this pr?

@YamatoAndo YamatoAndo requested a review from shmpwk November 21, 2024 07:29
@YamatoAndo
Copy link
Contributor

@kimurariku @shmpwk Please review

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk
Copy link
Contributor

shmpwk commented Dec 5, 2024

@a-maumau Ready to merge?

@a-maumau
Copy link
Contributor Author

a-maumau commented Dec 6, 2024

@shmpwk yes, please!

@shmpwk shmpwk merged commit 605eade into tier4:tier4/universe Dec 6, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants