Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aip_xx1_gen2_launch): add aip xx1 gen2 launch again #326 #327

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Oct 7, 2024

cherry-pick: feat(aip_xx1_gen2_launch): add aip xx1 gen2 launch again #326

This PR adds aip_xx1_gen2_launcher for XX1 gen2.

  • Adding aip_xx1_gen2_launch , aip_xx1_gen2_description
  • Modified nebula_node_container.launch to control the statup of hw_monitor.
  • Added hesai_OT128.launch.xml & modified hesai_XT32.launch.xml to pass the parameters correctly.

Since there was an issue where the nebula hardware monitor would crash on XX1 (see also #280), this PR ensures that the hardware monitor is only launched when starting XT32 or OT128.

yukkysaito and others added 12 commits October 7, 2024 18:12
* update for xx1 gen2

Signed-off-by: Yukihiro Saito <[email protected]>

* set network configs

Signed-off-by: Yuki Takagi <[email protected]>

* use angle param
add OT128 launch

Signed-off-by: Yuki Takagi <[email protected]>

* set lidar horizontal FOV angle

Signed-off-by: Yuki Takagi <[email protected]>

* update settings

Signed-off-by: Yuki Takagi <[email protected]>

* update

Signed-off-by: Yuki Takagi <[email protected]>

* add OT128 launch

Signed-off-by: Yuki Takagi <[email protected]>

* add ptp param

Signed-off-by: yuki.takagi@car_8 <[email protected]>

* complete to write lidar settings

Signed-off-by: yuki.takagi@car_8 <[email protected]>

* ci(pre-commit): autofix

* chore: generalized radar names

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* feat(aip_xx1_description): update side lidar name

Signed-off-by: yuki.takagi@car_8 <[email protected]>

* feat(aip_xx1_launch): enable imu in adm ecus

Signed-off-by: yuki.takagi@car_8 <[email protected]>

* change concate lidars

* update for xx1 gen2

* rotate top lidar 180

* change imu_corrector param aip_x2 -> aip_xx1

* enable gnss

* fix wrong urdf model for OT128

* fix bug

Signed-off-by: Yukihiro Saito <[email protected]>

* change max_range

* feat: added the radars to the aip launcher and description

Signed-off-by: j4tfwm6z <[email protected]>

* add nebula argments

* fix: fixed naming and enabled the radars

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix pointcloud preprocess for multi_lidar_ogm

* feat: enable radar launch and concatenation for all lidars

Signed-off-by: j4tfwm6z <[email protected]>

* fix(hesai_xt32): update ptp_transport_type from l2 to udp for xt32

Signed-off-by: j4tfwm6z <[email protected]>

* feat: added an option to select the frame of the radar objects

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* feat: add ptp_switch_type to support latest nebula at 2024/03/15 (#222)

Signed-off-by: j4tfwm6z <[email protected]>
Co-authored-by: j4tfwm6z <[email protected]>

* feat: add radar feature

Signed-off-by: yoshiri <[email protected]>

* fix: revert commenting out of radar.launch.xml

Signed-off-by: kminoda <[email protected]>

* add new folders

Signed-off-by: Yuxuan Liu <[email protected]>

* ci(pre-commit): autofix

* add folders for description

Signed-off-by: Yuxuan Liu <[email protected]>

* ci(pre-commit): autofix

* fix Spell-check

Signed-off-by: Yuxuan Liu <[email protected]>

* fix package name

Signed-off-by: Yuxuan Liu <[email protected]>

* fix: recover radar.xacro to make gen1 operational

Signed-off-by: N-Eiki <[email protected]>

* ci(pre-commit): autofix

* update aip_xx1 for gen2

Signed-off-by: N-Eiki <[email protected]>

* fix: packages name is aip_xx1_gen2_* but in these files written as aip_xx1_*

Signed-off-by: N-Eiki <[email protected]>

---------

Signed-off-by: Yukihiro Saito <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: yuki.takagi@car_8 <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: j4tfwm6z <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: Yuxuan Liu <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
Co-authored-by: Yuki Takagi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenzo Lobos-Tsunekawa <[email protected]>
Co-authored-by: j4tfwm6z <[email protected]>
Co-authored-by: kminoda <[email protected]>
Co-authored-by: yoshiri <[email protected]>
Co-authored-by: kminoda <[email protected]>
Co-authored-by: Yuxuan Liu <[email protected]>
Co-authored-by: Yuxuan Liu <[email protected]>
Co-authored-by: N-Eiki <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
@KYabuuchi KYabuuchi changed the title feat(aip_xx1_description): update for xx1 gen2 (#210) feat(aip_xx1_gen2_launch): add aip xx1 gen2 launch again #326 Oct 7, 2024
@KYabuuchi KYabuuchi requested review from zusizusi and shmpwk October 7, 2024 09:25
@KYabuuchi KYabuuchi marked this pull request as ready for review October 7, 2024 10:22
shmpwk
shmpwk previously approved these changes Oct 8, 2024
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kento Yabuuchi <[email protected]>
@KYabuuchi KYabuuchi merged commit 518c4d9 into tier4/universe Oct 8, 2024
9 of 10 checks passed
@KYabuuchi KYabuuchi deleted the cherry-pick/aip_xx1_gen2_launch_again branch October 8, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants