Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: temporary radar support for x2 gen2 v4.0.1 #357

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 12, 2024

@TomohitoAndo

ARS548を簡易的に使うための設定変更PRです.内容としては下記を含みます.

  • 左右のradarの無効化
  • motion compensationの無効化(ARS548になってセンサ側でこれができるようになったため)

思っていたのと挙動が違うので一旦draftに戻します.

@YoshiRi YoshiRi changed the title Feat/gen2 temp radar setting feat: temporary radar support for x2 gen2 v4.0.1 Dec 12, 2024
@YoshiRi YoshiRi marked this pull request as draft December 12, 2024 04:19
@YoshiRi YoshiRi requested a review from TomohitoAndo December 12, 2024 04:19
@YoshiRi YoshiRi marked this pull request as ready for review December 12, 2024 04:44
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Dec 12, 2024

前後の点群とradarの重畳の結果一旦まともそうに見えるのでtmpとしては行けると思います。(全体のlatencyは別途確認したいです。)
Screenshot from 2024-12-12 13-44-22

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Dec 12, 2024

camera_lidar_radarのモードに入らない限り影響しない一般的な変更なのでmergeします.

@YoshiRi YoshiRi merged commit af5f318 into beta/x2_gen2/v0.29.0 Dec 12, 2024
11 of 14 checks passed
@YoshiRi YoshiRi deleted the feat/gen2_temp_radar_setting branch December 12, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant