feat: add autoware_ prefix to diagnostic_graph_utils in tier4_system_component.launch.xml #741
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…component.launch.xml Signed-off-by: Ryohsuke Mitsudome <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Merged
14 tasks
sasakisasaki
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Quick Comment
Thank you for fixing!
Reason for Approval
This PR is for the update by this prefix PR. Thus, if let's we merge this PR and the prefix PR at the same time, I believe it'll be working 👍
(EDITED): The prefix PR is tested appropreately. That's why I said "let's merge this PR and the prefix PR at the same time" above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds autoware_ prefix to diagnostic_graph_utils package used in tier4_system_component.launch.xml
For the details, please refer to autowarefoundation/autoware.universe#9968
How was this PR tested?
Made sure that autoware_launch launches correctly:
ros2 launch autoware_launch autoware.launch.xml vehicle_model:=sample_vehicle sensor_model:=aip_xx1 map_path:=/home/mitsudome-r/autoware_map/nishishinjuku_autoware_map/
Notes for reviewers
Please merge this with autowarefoundation/autoware.universe#9968.
Effects on system behavior
None.