Skip to content

Commit

Permalink
revert: revert rename of use_pointcloud_container
Browse files Browse the repository at this point in the history
Signed-off-by: kminoda <[email protected]>
  • Loading branch information
kminoda committed Jan 16, 2024
1 parent 68ec5ee commit 6f28ecf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions awsim_sensor_kit_launch/launch/lidar.launch.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<launch>
<arg name="use_concat_filter" default="true"/>
<arg name="vehicle_mirror_param_file"/>
<arg name="include_concat_node_in_pointcloud_container" default="false" description="include concat node in pointcloud_container"/>
<arg name="use_pointcloud_container" default="false" description="include concat node in pointcloud_container"/>
<arg name="pointcloud_container_name" default="pointcloud_container"/>
<arg name="use_distortion_corrector" default="true"/>

Expand Down Expand Up @@ -36,7 +36,7 @@
<arg name="base_frame" value="base_link"/>
<arg name="use_intra_process" value="true"/>
<arg name="use_multithread" value="true"/>
<arg name="include_concat_node_in_pointcloud_container" value="$(var include_concat_node_in_pointcloud_container)"/>
<arg name="use_pointcloud_container" value="$(var use_pointcloud_container)"/>
<arg name="pointcloud_container_name" value="$(var pointcloud_container_name)"/>
</include>
</group>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ def launch_setup(context, *args, **kwargs):
package="rclcpp_components",
executable=LaunchConfiguration("container_executable"),
composable_node_descriptions=[],
condition=UnlessCondition(LaunchConfiguration("include_concat_node_in_pointcloud_container")),
condition=UnlessCondition(LaunchConfiguration("use_pointcloud_container")),
output="screen",
)

target_container = (
container
if UnlessCondition(LaunchConfiguration("include_concat_node_in_pointcloud_container")).evaluate(context)
if UnlessCondition(LaunchConfiguration("use_pointcloud_container")).evaluate(context)
else LaunchConfiguration("pointcloud_container_name")
)

Expand All @@ -88,7 +88,7 @@ def add_launch_arg(name: str, default_value=None):
add_launch_arg("base_frame", "base_link")
add_launch_arg("use_multithread", "False")
add_launch_arg("use_intra_process", "False")
add_launch_arg("include_concat_node_in_pointcloud_container", "False")
add_launch_arg("use_pointcloud_container", "False")
add_launch_arg("pointcloud_container_name", "pointcloud_container")
add_launch_arg("individual_container_name", "concatenate_container")

Expand Down
4 changes: 2 additions & 2 deletions awsim_sensor_kit_launch/launch/sensing.launch.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
<!-- Launch driver argument is not used since the AWSIM doesn't need any hardware drivers. -->
<!-- <arg name="launch_driver" default="true" description="do launch driver"/> -->
<arg name="vehicle_mirror_param_file" description="path to the file of vehicle mirror position yaml"/>
<arg name="include_concat_node_in_pointcloud_container" default="false" description="launch pointcloud container"/>
<arg name="use_pointcloud_container" default="false" description="launch pointcloud container"/>
<arg name="pointcloud_container_name" default="pointcloud_container"/>
<arg name="use_distortion_corrector" default="false" description="compensate the point cloud distortion caused by vehicle movement"/>

<group>
<!-- LiDAR Driver -->
<include file="$(find-pkg-share awsim_sensor_kit_launch)/launch/lidar.launch.xml">
<arg name="vehicle_mirror_param_file" value="$(var vehicle_mirror_param_file)"/>
<arg name="include_concat_node_in_pointcloud_container" value="$(var include_concat_node_in_pointcloud_container)"/>
<arg name="use_pointcloud_container" value="$(var use_pointcloud_container)"/>
<arg name="pointcloud_container_name" value="$(var pointcloud_container_name)"/>
<arg name="use_distortion_corrector" value="$(var use_distortion_corrector)"/>
</include>
Expand Down

0 comments on commit 6f28ecf

Please sign in to comment.