Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore timeout_sec #24

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

SakodaShintaro
Copy link
Contributor

Description

Currently, AWSIM publishes only the top lidar data. As a result, the concatenate node waits for the left and right lidar data until it reaches the timeout.

In a previous change (#22), the timeout_sec argument was removed, which changed the actual value of timeout_sec from 0.01 to 0.033. This has caused performance degradation in autoware_ekf_localizer due to slower lidar data publishing.

This pull request addresses the issue by restoring the appropriate timeout setting.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro SakodaShintaro requested a review from rej55 November 7, 2024 06:33
@SakodaShintaro SakodaShintaro self-assigned this Nov 7, 2024
@rej55 rej55 requested a review from drwnz November 7, 2024 07:00
@SakodaShintaro SakodaShintaro merged commit 63213e9 into tier4:main Nov 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants