This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
feat: update dependency.repos to clone renewal core repositories
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
hayato-m126
suggested changes
Jun 25, 2024
There was a problem hiding this comment.
Using lanelet2_extension_python in a split repository causes errors
2024-06-25T14:33:53.8396679Z 1: E SystemError: initialization of _autoware_lanelet2_extension_python_boost_python_regulatory_elements raised unreported exception
2024-06-25T14:33:53.8397459Z 1: =============================== warnings summary ===============================
2024-06-25T14:33:53.8398099Z 1: ../../../../../../usr/lib/python3/dist-packages/transforms3d/quaternions.py:26
2024-06-25T14:33:53.8398739Z 1: ../../../../../../usr/lib/python3/dist-packages/transforms3d/quaternions.py:27
2024-06-25T14:33:53.8400032Z 1: Warning: `np.float` is a deprecated alias for the builtin `float`. To silence this warning, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
2024-06-25T14:33:53.8401912Z 1: Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
2024-06-25T14:33:53.8402591Z 1:
2024-06-25T14:33:53.8402940Z 1: -- Docs: https://docs.pytest.org/en/stable/warnings.html
2024-06-25T14:33:53.8404034Z 1: - generated xml file: /__w/driving_log_replayer/driving_log_replayer/ros_ws/build/driving_log_replayer/test_results/driving_log_replayer/driving_log_replayer.xunit.xml -
2024-06-25T14:33:53.8404963Z 1: =========================== short test summary info ============================
2024-06-25T14:33:53.8405591Z 1: ERROR ../.. - SystemError: initialization of _autoware_lanelet2_extension_pyt...
2024-06-25T14:33:53.8406196Z 1: !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
2024-06-25T14:33:53.8406772Z 1: ========================= 2 warnings, 1 error in 0.66s =========================Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
youtalk
changed the title
autoware_ prefix to lanelet2_extensiondependency.repos to clone renewal core repositories excepts autoware_lanelet2_extension
youtalk
changed the title
dependency.repos to clone renewal core repositories excepts autoware_lanelet2_extensiondependency.repos to clone renewal core repositories
|
@hayato-m126 I minimized this PR changes and hope to pass the tests. Please review again. |
hayato-m126
approved these changes
Jul 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of PR
Description
This PR adds
autoware_prefix tolanelet2_extension.ref. https://github.com/orgs/autowarefoundation/discussions/4097
Additionally, this PR also changed the
autoware_lanelet2_extensionto pull from https://github.com/autowarefoundation/autoware_lanelet2_extension not from https://github.com/autowarefoundation/autoware_common.ref. https://github.com/orgs/autowarefoundation/discussions/4671
autowarefoundation/autoware#4911
How to review this PR
This PR is a fix to accommodate both the deprecated
lanelet2_extensionand the newautoware_lanelet2_extension.So I hope it shouldn't require a deep review.
Others