-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update edge_auto_launcher tasks #57
Conversation
- Added a task to check if the GitHub API return is valid - Added a task to ensure driver_deb_download_url is defined - Added tasks to extract and fix the driver tar.gz file - Added a task to run the installation script - Removed the task to install the driver from deb file - Removed the task to install the SDK from deb file - Updated the task to setup camera driver and SDK
@tokuda99 @amc-nu |
Signed-off-by: urasakikeisuke <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
@manato @drwnz diff --git a/perception/autoware_tensorrt_yolox/include/autoware/tensorrt_yolox/tensorrt_yolox_node.hpp b/perception/autoware_tensorrt_yolox/include/autoware/tensorrt_yolox/tensorrt_yolox_node.hpp
index 7f622b2dc8..cf7b051b9e 100644
--- a/perception/autoware_tensorrt_yolox/include/autoware/tensorrt_yolox/tensorrt_yolox_node.hpp
+++ b/perception/autoware_tensorrt_yolox/include/autoware/tensorrt_yolox/tensorrt_yolox_node.hpp
@@ -42,8 +42,8 @@
#include <string>
#include <vector>
-namespace autoware::tensorrt_yolox
-{
+namespace autoware {
+namespace tensorrt_yolox {
// cspell: ignore Semseg
using LabelMap = std::map<int, std::string>;
using Label = tier4_perception_msgs::msg::Semantic;
@@ -110,6 +110,6 @@ private:
std::unique_ptr<autoware::universe_utils::DebugPublisher> debug_publisher_;
};
-} // namespace autoware::tensorrt_yolox
-
+} // namespace tensorrt_yolox
+} // namespace autoware
#endif // AUTOWARE__TENSORRT_YOLOX__TENSORRT_YOLOX_NODE_HPP_
diff --git a/perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp b/perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp
index f3c7b2552e..ed57c598be 100644
--- a/perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp
+++ b/perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp
@@ -24,8 +24,8 @@
#include <utility>
#include <vector>
-namespace autoware::tensorrt_yolox
-{
+namespace autoware {
+namespace tensorrt_yolox {
TrtYoloXNode::TrtYoloXNode(const rclcpp::NodeOptions & node_options)
: Node("tensorrt_yolox", node_options)
{
@@ -281,7 +281,8 @@ void TrtYoloXNode::overlapSegmentByRoi(
.rowRange(roi_y_offset, roi_y_offset + roi_height));
}
-} // namespace autoware::tensorrt_yolox
+} // namespace tensorrt_yolox
+} // namespace autoware
#include "rclcpp_components/register_node_macro.hpp"
RCLCPP_COMPONENTS_REGISTER_NODE(autoware::tensorrt_yolox::TrtYoloXNode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amc-nu @tokuda99 @urasakikeisuke
I appreciate your support! Similar to tier4/edge-auto#19, I approve this PR as a first step for updating.
@amc-nu @tokuda99 @urasakikeisuke |
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
Signed-off-by: amc-nu <[email protected]>
@manato fixed the remaining issues. Ansible linting is still failing, but the files are unrelated to this PR. |
@amc-nu |
Verified using the following command, after a successful installation with ansible and a restart to allow the camera driver to load.
ros2 launch edge_auto_jetson_launch edge_auto_jetson.launch.xml